Scheduler - Unskip testcafe tests#33200
Conversation
| ].forEach(({ views, expect, crossScrollingEnabled }) => { | ||
| views.forEach((view) => { | ||
| test.skip( | ||
| test( |
There was a problem hiding this comment.
Looking at the history:
https://github.com/Tucchhaa/DevExtreme/blame/b7f2e313133634034b38ecba8b20f81a76fed120/e2e/testcafe-devextreme/tests/scheduler/common/layout/customization/cellSizesCss.ts#L98
This test was skipped from the moment it was added, looks like it was an accident, so I just unskipped it
| currentDate: new Date(2020, 8, 7), | ||
| scrolling: { | ||
| mode: 'virtual', | ||
| orientation: 'both', |
There was a problem hiding this comment.
Private option, I removed it, because the default value is also 'both':
| scrolling: { | ||
| mode: 'virtual', | ||
| orientation: 'both', | ||
| outlineCount: 0, |
There was a problem hiding this comment.
Private option. This option determines how many rows or columns to render outside the viewport if virtual scrolling is enabled. It's redundant in the case of this test, because appointment is always in the viewport (on init and after scroll)
| const scheduler = new Scheduler('#container'); | ||
| const { element } = scheduler.getAppointment('', 0); | ||
|
|
||
| await setStyleAttribute(element, 'background-color: red;'); |
There was a problem hiding this comment.
This background-color is set here just to check if the value of the style attr hasn't changed (if appt is rerendered then style attr value will reset)
There was a problem hiding this comment.
Pull request overview
This PR re-enables previously skipped Scheduler TestCafe coverage by unskipping two tests and adjusting one test’s expectations/config so it can run in CI.
Changes:
- Unskipped the virtual scrolling “appointment should not repaint after scrolling” test and updated it to compare against the captured initial inline style.
- Removed
scrolling.orientationandscrolling.outlineCountfrom the virtual scrolling scheduler setup. - Unskipped the “cell sizes CSS classes” layout customization test matrix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| e2e/testcafe-devextreme/tests/scheduler/common/virtualScrolling/appointments.ts | Unskips a virtual scrolling test, relaxes the style assertion by capturing the initial style, and removes extra scrolling options. |
| e2e/testcafe-devextreme/tests/scheduler/common/layout/customization/cellSizesCss.ts | Unskips the cell size/CSS class verification tests across views and cross-scrolling modes. |
No description provided.