[react] Add commandFor and command attributes to ButtonHTMLAttributes#75296
[react] Add commandFor and command attributes to ButtonHTMLAttributes#75296deepshekhardas wants to merge 1 commit into
Conversation
|
@deepshekhardas Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75296,
"author": "deepshekhardas",
"headCommitOid": "36eac536c03e7177231544f206b6a5f6c6b5af63",
"mergeBaseOid": "181ddbf1c83693aa092fcf1dcf234ea350b327a0",
"lastPushDate": "2026-07-22T01:24:22.000Z",
"lastActivityDate": "2026-07-22T01:24:22.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react",
"kind": "edit",
"files": [
{
"path": "types/react/index.d.ts",
"kind": "definition"
},
{
"path": "types/react/ts5.0/index.d.ts",
"kind": "definition"
}
],
"owners": [
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"ericanderson",
"DovydasNavickas",
"theruther4d",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"Jessidhia",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag",
"priyanshurav",
"Semigradsky",
"mattpocock"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 5040788664,
"ciResult": "pass"
} |
|
Hey @deepshekhardas, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @eps1lon @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @priyanshurav @Semigradsky @mattpocock — please review this PR in the next few days. Be sure to explicitly select |
Adds the \commandFor\ and \command\ attributes to \ButtonHTMLAttributes\ as specified by the Invoker Commands API (whatwg/html#9841).
These attributes are already supported in Chrome/Edge 135+ and Safari TP.
Fixes #74664