Skip to content

mpv-script: add mp.input.*#75210

Open
sharpchen wants to merge 1 commit into
DefinitelyTyped:masterfrom
sharpchen:mpv-input
Open

mpv-script: add mp.input.*#75210
sharpchen wants to merge 1 commit into
DefinitelyTyped:masterfrom
sharpchen:mpv-input

Conversation

@sharpchen

Copy link
Copy Markdown

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-automation

typescript-automation Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

@sharpchen Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75210,
  "author": "sharpchen",
  "headCommitOid": "aaffa36e65f3205f5af7150942c667ac3601ffc1",
  "mergeBaseOid": "e2580e07bfb619bbaa80a31c6e9d0e2ec35fea22",
  "lastPushDate": "2026-07-05T06:02:21.000Z",
  "lastActivityDate": "2026-07-05T06:02:21.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "mpv-script",
      "kind": "edit",
      "files": [
        {
          "path": "types/mpv-script/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "mrxdst"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 4885036439,
  "ciResult": "pass"
}

@typescript-automation typescript-automation Bot added the Untested Change This PR does not touch tests label Jul 5, 2026
@typescript-automation typescript-automation Bot moved this to Waiting for Code Reviews in Pull Request Status Board Jul 5, 2026
@typescript-automation

Copy link
Copy Markdown
Contributor

Hey @sharpchen,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-automation

Copy link
Copy Markdown
Contributor

🔔 @mrxdst — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-automation typescript-automation Bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Untested Change This PR does not touch tests

Projects

Status: Needs Maintainer Review

Development

Successfully merging this pull request may close these issues.

1 participant