Skip to content

chore: remove pnpm overrides field#75206

Open
hkleungai wants to merge 1 commit into
DefinitelyTyped:masterfrom
hkleungai:remove-pnpm-overrides
Open

chore: remove pnpm overrides field#75206
hkleungai wants to merge 1 commit into
DefinitelyTyped:masterfrom
hkleungai:remove-pnpm-overrides

Conversation

@hkleungai

Copy link
Copy Markdown
Contributor

Infra change, to get rid of the annoying warning message.

The "pnpm" field in package.json is no longer read by pnpm. The following keys were ignored: "pnpm.overrides". See https://pnpm.io/settings for the new home of each setting.

From the warning, I suspect the override field is no longer useful and hence no longer needed.

@typescript-automation

typescript-automation Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

@hkleungai Thank you for submitting this PR!

This is a live comment that I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

0 packages in this PR (and infra files)

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes that affect DT infrastructure (package.json)

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75206,
  "author": "hkleungai",
  "headCommitOid": "327963e59230976cf221bc2a5e93ab9d0d3db092",
  "mergeBaseOid": "a5f20e597c9a9d4ab2975dab57e8edc26ad020d8",
  "lastPushDate": "2026-07-04T08:16:48.000Z",
  "lastActivityDate": "2026-07-04T08:16:48.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "package.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical",
      "isSafeInfrastructureEdit": false
    }
  ],
  "reviews": [],
  "mainBotCommentID": 4881265105,
  "ciResult": "pass"
}

@typescript-automation

Copy link
Copy Markdown
Contributor

🔔 @hkleungai — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-automation typescript-automation Bot moved this to Waiting for Code Reviews in Pull Request Status Board Jul 4, 2026
@typescript-automation typescript-automation Bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs Maintainer Action

Development

Successfully merging this pull request may close these issues.

1 participant