Skip to content

[safie-sdk] Update to v1.9#75181

Open
yusuke-oba1 wants to merge 2 commits into
DefinitelyTyped:masterfrom
yusuke-oba1:safie-sdk-1.9
Open

[safie-sdk] Update to v1.9#75181
yusuke-oba1 wants to merge 2 commits into
DefinitelyTyped:masterfrom
yusuke-oba1:safie-sdk-1.9

Conversation

@yusuke-oba1

@yusuke-oba1 yusuke-oba1 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Updates @types/safie-sdk to track Safie Developers JavaScript SDK v1.9.

Changes

  • Add Safie.Config.Theme namespace (set / get, ThemeType = 'light' | 'dark' | 'system')
  • Add deviceIds filter option to Safie.Devices.queryDevices
  • Expose Device.capabilities as a documented string[] field (previously @hidden / optional)
  • Remove an obsolete hybrid-recording limitation note from the player config docs
  • Add yusuke-oba1 as an individual package owner alongside the existing SafieDev org

safie-sdk-tests.ts is updated to exercise the new APIs.

Checklist

  • Bumped the version in package.json (1.8.99991.9.9999)
  • Tested locally: dprint check and tsc pass
  • This is a non-npm package; the source SDK is published at https://developers.safie.link/

Opened as a draft for internal review before requesting maintainer review.

- Add Safie.Config.Theme namespace (set/get, ThemeType)
- Add deviceIds filter option to Safie.Devices.queryDevices
- Expose Device.capabilities as a documented string[] field
- Remove obsolete hybrid-recording limitation note

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add the individual maintainer alongside the existing SafieDev org so
owner-authored updates can follow the normal review/merge flow.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@yusuke-oba1 yusuke-oba1 marked this pull request as ready for review June 30, 2026 06:43
@typescript-automation

typescript-automation Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@yusuke-oba1 Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75181,
  "author": "yusuke-oba1",
  "headCommitOid": "2cc752d88f7cbc48c91901d0c83812ffb8bebe80",
  "mergeBaseOid": "306ff872184adba73ff929c944b468d45433e52b",
  "lastPushDate": "2026-06-30T05:31:05.000Z",
  "lastActivityDate": "2026-06-30T07:06:22.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "safie-sdk",
      "kind": "edit",
      "files": [
        {
          "path": "types/safie-sdk/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/safie-sdk/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/safie-sdk/safie-sdk-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "SafieDev"
      ],
      "addedOwners": [
        "yusuke-oba1"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 4840628953,
  "ciResult": "pass"
}

@typescript-automation typescript-automation Bot added the Edits Owners This PR adds or removes owners label Jun 30, 2026
@typescript-automation typescript-automation Bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board Jun 30, 2026
@typescript-automation

Copy link
Copy Markdown
Contributor

🔔 @SafieDev — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@yusuke-oba1

Copy link
Copy Markdown
Contributor Author

The currently-listed owner SafieDev is our organization account, which cannot submit a PR review in the GitHub UI. I'm a member of the Safie Inc. org and the maintainer of this SDK, so this PR adds my individual account yusuke-oba1 as an owner (alongside SafieDev) to follow the usual DT pattern of listing individual maintainers.

Could a maintainer please review the ownership change? Happy to provide any verification needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Edits Owners This PR adds or removes owners

Projects

Status: Waiting for Code Reviews

Development

Successfully merging this pull request may close these issues.

1 participant