Skip to content

google-apps-scripts: Add support for Tables to Sheets API.#75171

Open
thromer wants to merge 4 commits into
DefinitelyTyped:masterfrom
thromer:master
Open

google-apps-scripts: Add support for Tables to Sheets API.#75171
thromer wants to merge 4 commits into
DefinitelyTyped:masterfrom
thromer:master

Conversation

@thromer

@thromer thromer commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Also, add optionalArgs variant to Sheets.Spreadsheets.getByDataFilter method.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change.
    • Added test covering the changed code. Not too confident in the approach I took. Also, manually tested that code exercising the new and modified definitions ran correctly after transpilation.
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run pnpm test <package to test>.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/googleapis/google-api-nodejs-client/blob/main/src/apis/sheets/v4.ts
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.
    • Not applicable -- existing google-apps-script/apis/sheets_v4.d.ts coverage of the full API is incomplete; this PR just fills in one gap.

@typescript-automation

typescript-automation Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

@thromer Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75171,
  "author": "thromer",
  "headCommitOid": "6b8b49aa9ac43a8199b6aa872ec9b8ba0cffbda1",
  "mergeBaseOid": "f0fe08f2bc1da7dfddc237fcf5cb7e97d928b377",
  "lastPushDate": "2026-06-27T05:41:21.000Z",
  "lastActivityDate": "2026-06-27T05:41:21.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "google-apps-script",
      "kind": "edit",
      "files": [
        {
          "path": "types/google-apps-script/apis/sheets_v4.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/test/google-apps-script-apis-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "jpoehnelt",
        "sqrrrl",
        "PierrickVoulet",
        "vinay-google"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 4815431288,
  "ciResult": "pass"
}

@typescript-automation typescript-automation Bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Jun 27, 2026
@typescript-automation typescript-automation Bot moved this to Waiting for Code Reviews in Pull Request Status Board Jun 27, 2026
@typescript-automation

Copy link
Copy Markdown
Contributor

🔔 @jpoehnelt @sqrrrl @PierrickVoulet @vinay-google — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-automation typescript-automation Bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Jun 27, 2026
@typescript-automation typescript-automation Bot removed the Untested Change This PR does not touch tests label Jun 27, 2026
@typescript-automation typescript-automation Bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Pull Request Status Board Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

Status: Waiting for Code Reviews

Development

Successfully merging this pull request may close these issues.

1 participant