Skip to content

fix(depd): Augmented process.listeners should return functions#75167

Open
RobinTail wants to merge 2 commits into
DefinitelyTyped:masterfrom
RobinTail:fix-depd-aug-process-listeners
Open

fix(depd): Augmented process.listeners should return functions#75167
RobinTail wants to merge 2 commits into
DefinitelyTyped:masterfrom
RobinTail:fix-depd-aug-process-listeners

Conversation

@RobinTail

@RobinTail RobinTail commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Description

process.listeners("deprecation") always returns an array of functions, not an array of errors.

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-automation typescript-automation Bot moved this to Needs Author Action in Pull Request Status Board Jun 26, 2026
@RobinTail RobinTail marked this pull request as ready for review June 26, 2026 12:57
@typescript-automation

typescript-automation Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@RobinTail Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 7 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75167,
  "author": "RobinTail",
  "headCommitOid": "4be825c45314ce6394c68b105342079102dff413",
  "mergeBaseOid": "0721118d783ca9454a738916f6c0a676c3f91629",
  "lastPushDate": "2026-06-26T12:46:55.000Z",
  "lastActivityDate": "2026-06-26T12:57:32.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "depd",
      "kind": "edit",
      "files": [
        {
          "path": "types/depd/depd-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/depd/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "danny8002",
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 4809798080,
  "ciResult": "pass"
}

@typescript-automation typescript-automation Bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Jun 26, 2026
@typescript-automation

Copy link
Copy Markdown
Contributor

🔔 @danny8002 @BendingBender — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-automation typescript-automation Bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

Status: Waiting for Code Reviews

Development

Successfully merging this pull request may close these issues.

1 participant