Skip to content

[mjml-core] Add includePath option (mjml 5.1)#75162

Open
NoMercy235 wants to merge 1 commit into
DefinitelyTyped:masterfrom
NoMercy235:mjml-core-include-path
Open

[mjml-core] Add includePath option (mjml 5.1)#75162
NoMercy235 wants to merge 1 commit into
DefinitelyTyped:masterfrom
NoMercy235:mjml-core-include-path

Conversation

@NoMercy235

Copy link
Copy Markdown

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: GHSA-45h5-66jx-r2wf (the advisory that introduced includePath)
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-automation

typescript-automation Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@NoMercy235 Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 8 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75162,
  "author": "NoMercy235",
  "headCommitOid": "f9ba1ccde94fcb11ec501fce354db25d5b72e931",
  "mergeBaseOid": "d41b1fdab96f6019d6d86ffdbb375ccdf3afe481",
  "lastPushDate": "2026-06-25T14:43:22.000Z",
  "lastActivityDate": "2026-06-25T14:43:22.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "mjml-core",
      "kind": "edit",
      "files": [
        {
          "path": "types/mjml-core/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mjml-core/mjml-core-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/mjml-core/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "IanEdington",
        "ryanburr"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 4800624854,
  "ciResult": "pass"
}

@typescript-automation typescript-automation Bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Jun 25, 2026
@typescript-automation

Copy link
Copy Markdown
Contributor

🔔 @IanEdington @ryanburr — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

Status: Waiting for Code Reviews

Development

Successfully merging this pull request may close these issues.

1 participant