Skip to content

[async] queue.push returns an array of promises when a task array is passed#75157

Open
Blond11516 wants to merge 1 commit into
DefinitelyTyped:masterfrom
Blond11516:async-queue-push-return-array
Open

[async] queue.push returns an array of promises when a task array is passed#75157
Blond11516 wants to merge 1 commit into
DefinitelyTyped:masterfrom
Blond11516:async-queue-push-return-array

Conversation

@Blond11516

Copy link
Copy Markdown

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@Blond11516 Blond11516 requested a review from borisyankov as a code owner June 22, 2026 16:43
@typescript-automation

typescript-automation Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@Blond11516 Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 11 days — please try to get reviewers!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75157,
  "author": "Blond11516",
  "headCommitOid": "af1004ac4324af16dce4b69064917516772b01b4",
  "mergeBaseOid": "8245541d4ca2f5952ca1264d9f476e5bd00d51bd",
  "lastPushDate": "2026-06-22T16:43:53.000Z",
  "lastActivityDate": "2026-06-22T16:45:03.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "async",
      "kind": "edit",
      "files": [
        {
          "path": "types/async/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/async/test/index.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "borisyankov",
        "kern0",
        "fenying",
        "pascalmartin",
        "erossignon",
        "Juliiii",
        "brendtumi",
        "apnsngr"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 4770690004,
  "ciResult": "pass"
}

@typescript-automation typescript-automation Bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Jun 22, 2026
@typescript-automation

Copy link
Copy Markdown
Contributor

🔔 @borisyankov @Kern0 @fenying @pascalmartin @erossignon @Juliiii @brendtumi @apnsngr — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-automation typescript-automation Bot moved this to Waiting for Code Reviews in Pull Request Status Board Jun 22, 2026
@Juliiii

Juliiii commented Jun 22, 2026 via email

Copy link
Copy Markdown
Contributor

@typescript-automation typescript-automation Bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Jul 3, 2026
@typescript-automation

Copy link
Copy Markdown
Contributor

Re-ping @borisyankov, @Kern0, @fenying, @pascalmartin, @erossignon, @Juliiii, @brendtumi, @apnsngr:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts). Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer.

Projects

Status: Waiting for Code Reviews

Development

Successfully merging this pull request may close these issues.

2 participants