Skip to content

[chrome] update since Chrome 149#75076

Open
erwanjugand wants to merge 1 commit into
DefinitelyTyped:masterfrom
erwanjugand:update-week-20
Open

[chrome] update since Chrome 149#75076
erwanjugand wants to merge 1 commit into
DefinitelyTyped:masterfrom
erwanjugand:update-week-20

Conversation

@erwanjugand
Copy link
Copy Markdown
Contributor

@erwanjugand erwanjugand commented Jun 2, 2026

Please fill in this template.

If changing an existing definition:

Notes:

  • deprecate chrome.runtime.PlatformNaclArch
  • fix typos

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 2, 2026

@erwanjugand Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75076,
  "author": "erwanjugand",
  "headCommitOid": "86436b5052f9151ff95af2b9db4e075565d2ba04",
  "mergeBaseOid": "06465458e0ab72258dfd5cd7b284748f8afa1f72",
  "lastPushDate": "2026-06-02T19:48:34.000Z",
  "lastActivityDate": "2026-06-02T20:18:57.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "chrome",
      "kind": "edit",
      "files": [
        {
          "path": "types/chrome/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "matthewkimber",
        "otiai10",
        "sreimer15",
        "MatCarlson",
        "ekinsol",
        "echoabstract",
        "spasma",
        "bdbai",
        "JasonXian",
        "usertim",
        "idan315",
        "nicolas377",
        "idosal",
        "fregante",
        "erwanjugand"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 4606463462,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels Jun 2, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @matthewkimber @otiai10 @sreimer15 @matcarlson @ekinsol @EchoAbstract @spasma @bdbai @JasonXian @userTim @idan315 @nicolas377 @idosal @fregante — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Jun 2, 2026
@erwanjugand erwanjugand force-pushed the update-week-20 branch 2 times, most recently from 70b11c3 to 17d83e1 Compare June 2, 2026 19:55
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Jun 2, 2026
@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label Jun 2, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

Hey @erwanjugand,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Pull Request Status Board Jun 2, 2026
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Jun 2, 2026
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Pull Request Status Board Jun 2, 2026
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Critical package Untested Change This PR does not touch tests

Projects

Status: Needs Maintainer Review

Development

Successfully merging this pull request may close these issues.

2 participants