Skip to content

[oracledb] Update types for node-oracledb 7.0 features#75075

Open
prajalg wants to merge 21 commits into
DefinitelyTyped:masterfrom
prajalg:oracledb-type-changes
Open

[oracledb] Update types for node-oracledb 7.0 features#75075
prajalg wants to merge 21 commits into
DefinitelyTyped:masterfrom
prajalg:oracledb-type-changes

Conversation

@prajalg
Copy link
Copy Markdown

@prajalg prajalg commented Jun 2, 2026

Summary

This PR updates @types/oracledb with node-oracledb 7.0-aligned type changes:

  • Added pipeline typings:
    • oracledb.Pipeline
    • pipeline.addCommit()
    • pipeline.addExecute()
    • pipeline.addExecuteMany()
    • pipeline.addFetchAll()
    • pipeline.addFetchMany()
    • pipeline.addFetchOne()
    • connection.runPipeline()
    • related pipeline option/result types
  • Added direct path load typings:
    • connection.directPathLoad()
    • DirectPathLoadColumns
    • DirectPathLoadData
  • Added application context typings:
    • connection.appContext()
    • connection.clearAppContext()
    • AppContextKeyValue
  • Added explicit resource management typings:
    • [Symbol.asyncDispose]() for Connection, Pool, and ResultSet
    • Added disposable lib support for explicit resource management:
  • Added connection properties:
    • connection.pdbName
    • connection.dbUniqueName
  • Added lob.trim() typings (Promise + callback overloads)
  • Added oracledb.thickModeDSNPassthrough
  • Added trace pool event hook methods to TraceHandlerBase
  • Added DBMS_ASSERT-related APIs:
    • oracledb.isSimpleSqlName()
    • oracledb.isQualifiedSqlName()
    • oracledb.enquoteLiteral()
    • oracledb.enquoteName()
  • Added End User Security Context typings:
    • oracledb.EndUserSecurityContext constructor typing
    • EndUserSecurityContextOptions
    • connection.setEndUserSecurityContext()
    • connection.clearEndUserSecurityContext()
  • Added version7Tests coverage in types/oracledb/oracledb-tests.ts
  • Updated package version:
    • types/oracledb/package.json: 6.10.9999 -> 7.0.9999

Checklist

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change.
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run pnpm test oracledb.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 2, 2026

@prajalg Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes that affect module config files

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75075,
  "author": "prajalg",
  "headCommitOid": "8891efa244de866a97227fb8f57b4d6d973790a0",
  "mergeBaseOid": "61d554a31c74c5a5b55aa201adb9dda576387ebf",
  "lastPushDate": "2026-06-02T17:20:42.000Z",
  "lastActivityDate": "2026-06-03T08:41:56.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "oracledb",
      "kind": "edit",
      "files": [
        {
          "path": "types/oracledb/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oracledb/oracledb-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/oracledb/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/oracledb/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.strictNullChecks`, `compilerOptions.lib.1`)"
        }
      ],
      "owners": [
        "connorjayfitzgerald",
        "dannyb648",
        "jacobwheale",
        "sudarshan12s",
        "sharadraju"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sudarshan12s",
      "date": "2026-06-03T08:41:56.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "sosoba",
      "date": "2026-06-03T07:05:51.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "sharadraju",
      "date": "2026-06-03T06:48:53.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 4605063880,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @connorjayfitzgerald @dannyb648 @jacobwheale @sudarshan12s @sharadraju — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Jun 2, 2026
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Jun 2, 2026
Copy link
Copy Markdown
Contributor

@sharadraju sharadraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jun 3, 2026
@sharadraju sharadraju mentioned this pull request Jun 3, 2026
8 tasks
@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Jun 3, 2026
Copy link
Copy Markdown
Contributor

@sudarshan12s sudarshan12s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Check Config Changes a module config files Critical package Other Approved This PR was reviewed and signed-off by a community member. Owner Approved A listed owner of this package signed off on the pull request.

Projects

Status: Needs Maintainer Review

Development

Successfully merging this pull request may close these issues.

5 participants