(mdx): add missing subpath exports map for types lookup#75059
(mdx): add missing subpath exports map for types lookup#75059talatkuyuk wants to merge 2 commits into
Conversation
|
@talatkuyuk Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75059,
"author": "talatkuyuk",
"headCommitOid": "c7c1901632d37714fcad703923883f62c9f0ddc8",
"mergeBaseOid": "d367b0514b079743f749259bd0f1fb627d079895",
"lastPushDate": "2026-05-29T14:34:41.000Z",
"lastActivityDate": "2026-06-01T15:03:22.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "mdx",
"kind": "edit",
"files": [
{
"path": "types/mdx/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"ChristianMurphy",
"remcohaszing",
"wooorm"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "ChristianMurphy",
"date": "2026-06-01T15:03:22.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "remcohaszing",
"date": "2026-05-31T09:31:54.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 4576351867,
"ciResult": "pass"
} |
|
🔔 @ChristianMurphy @remcohaszing @wooorm — please review this PR in the next few days. Be sure to explicitly select |
|
@talatkuyuk One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
Co-authored-by: Remco Haszing <remcohaszing@gmail.com>
|
@remcohaszing Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
⏳ Hi @talatkuyuk, It's been a few days since this PR was approved by ChristianMurphy, remcohaszing and we're waiting for a DT maintainer to give a review. If you would like to short-circuit this wait, you can edit some of the test files in the package that verify how the |
Please fill in this template.
pnpm test <package to test>.If changing an existing definition:
package.json.Summary
Added explicit subpath
"exports"totypes/mdx/package.json.Context
The package internally targets types from
"mdx/types". However, without an explicit subpath exports entry inpackage.json, environments compiling code using modern TypeScript configurations like"moduleResolution": "bundler"or"moduleResolution": "nodenext"fail to resolve the path ifskipLibCheckis disabled, throwing aCannot find module 'mdx/types' or its corresponding type declarationserror. (I faced with it in in next-mdx-remote-client)Adding the
exportsfield matches the package lookup requirements and guarantees uniform type resolution across both modern and legacy TS compilation options.