Removing openseadragon as it now bundles its own types#75010
Conversation
|
@iangilman Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 1 package in this PR (and infra files)Code ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75010,
"author": "iangilman",
"headCommitOid": "62d591ecf4a70a2553ba2ac87eab5970409bf24d",
"mergeBaseOid": "ca06abb4cc3399ea070c122be329a22f1c3b6800",
"lastPushDate": "2026-05-15T18:58:04.000Z",
"lastActivityDate": "2026-05-15T19:03:24.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical",
"isSafeInfrastructureEdit": false
},
{
"name": "openseadragon",
"kind": "delete",
"files": [
{
"path": "types/openseadragon/.eslintrc.json",
"kind": "package-meta-ok"
},
{
"path": "types/openseadragon/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/openseadragon/index.d.ts",
"kind": "definition"
},
{
"path": "types/openseadragon/openseadragon-tests.ts",
"kind": "test"
},
{
"path": "types/openseadragon/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/openseadragon/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"alvaromartmart",
"jstaab",
"kristinruben",
"geoff-harper",
"justincy",
"peterblazejewicz",
"rssaini01"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 4462520321,
"ciResult": "pass"
} |
|
🔔 @alvaromartmart @jstaab @kristinruben @geoff-harper @justincy @peterblazejewicz @rssaini01 — please review this PR in the next few days. Be sure to explicitly select |
|
Just to confirm, DefinitelyTyped types for earlier versions of openseadragon (pre-6.0.0) will still be available after this change, correct? I suppose so, because they are already published to npm. Just feeling paranoid… Oh, and just to be explicit: I am the lead maintainer of https://github.com/openseadragon/openseadragon, the package affected. We added https://github.com/openseadragon/openseadragon/blob/master/types/index.d.ts to that project starting with openseadragon/openseadragon#2813 and released them with the 6.0.0 release: https://github.com/openseadragon/openseadragon/releases/tag/v6.0.0 |
Please fill in this template.
Select one of these and delete the others:
If removing a declaration:
notNeededPackages.json.