Skip to content

Add "generative" as a pageType for navigateTo in @types/xrm#74985

Open
derekfinlinson wants to merge 16 commits into
DefinitelyTyped:masterfrom
derekfinlinson:master
Open

Add "generative" as a pageType for navigateTo in @types/xrm#74985
derekfinlinson wants to merge 16 commits into
DefinitelyTyped:masterfrom
derekfinlinson:master

Conversation

@derekfinlinson
Copy link
Copy Markdown
Contributor

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 11, 2026

@derekfinlinson Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74985,
  "author": "derekfinlinson",
  "headCommitOid": "318e18405b8cab6c23ebf94899aa0ce1c10a3fa1",
  "mergeBaseOid": "1d859fa5f1c4b759f25935c4e3257a63237a4efe",
  "lastPushDate": "2026-05-11T21:48:25.000Z",
  "lastActivityDate": "2026-05-12T02:45:50.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "xrm",
      "kind": "edit",
      "files": [
        {
          "path": "types/xrm/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xrm/xrm-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "mattngan",
        "markusmauch",
        "daryllabar",
        "clownwilleatme",
        "scottdurow",
        "filcole",
        "power-maverick",
        "gncnpk"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "daryllabar",
      "date": "2026-05-12T02:45:50.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 4425455268,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @mattngan @markusmauch @daryllabar @clownwilleatme @scottdurow @filcole @Power-Maverick @gncnpk — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS
Copy link
Copy Markdown

Formatting

The following files are not formatted:

  1. types/xrm/xrm-tests.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against c14d58b

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels May 12, 2026
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board May 12, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

@derekfinlinson: Everything looks good here. I am ready to merge this PR (at 318e184) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@mattngan, @markusmauch, @daryllabar, @clownwilleatme, @scottdurow, @filcole, @Power-Maverick, @gncnpk: you can do this too.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

Status: Waiting for Author to Merge

Development

Successfully merging this pull request may close these issues.

4 participants