node: v26#74983
Open
hitsthings wants to merge 5 commits into
Open
Conversation
Contributor
|
@hitsthings Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74983,
"author": "hitsthings",
"headCommitOid": "ba388b7c4d7fa37f0d3014b67bf7cc6320152033",
"mergeBaseOid": "a00761a602d90872375dbeceb7b6cba3adb60da1",
"lastPushDate": "2026-05-11T20:23:53.000Z",
"lastActivityDate": "2026-05-11T21:05:29.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": true,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/node/assert.d.ts",
"kind": "definition"
},
{
"path": "types/node/assert/strict.d.ts",
"kind": "definition"
},
{
"path": "types/node/async_hooks.d.ts",
"kind": "definition"
},
{
"path": "types/node/child_process.d.ts",
"kind": "definition"
},
{
"path": "types/node/cluster.d.ts",
"kind": "definition"
},
{
"path": "types/node/console.d.ts",
"kind": "definition"
},
{
"path": "types/node/crypto.d.ts",
"kind": "definition"
},
{
"path": "types/node/dns.d.ts",
"kind": "definition"
},
{
"path": "types/node/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/globals.d.ts",
"kind": "definition"
},
{
"path": "types/node/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/http2.d.ts",
"kind": "definition"
},
{
"path": "types/node/inspector.d.ts",
"kind": "definition"
},
{
"path": "types/node/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/net.d.ts",
"kind": "definition"
},
{
"path": "types/node/node-tests/assert.ts",
"kind": "test"
},
{
"path": "types/node/node-tests/crypto.ts",
"kind": "test"
},
{
"path": "types/node/node-tests/globals.ts",
"kind": "test"
},
{
"path": "types/node/os.d.ts",
"kind": "definition"
},
{
"path": "types/node/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/perf_hooks.d.ts",
"kind": "definition"
},
{
"path": "types/node/process.d.ts",
"kind": "definition"
},
{
"path": "types/node/readline.d.ts",
"kind": "definition"
},
{
"path": "types/node/repl.d.ts",
"kind": "definition"
},
{
"path": "types/node/sqlite.d.ts",
"kind": "definition"
},
{
"path": "types/node/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/stream/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/reporters.d.ts",
"kind": "definition"
},
{
"path": "types/node/tls.d.ts",
"kind": "definition"
},
{
"path": "types/node/url.d.ts",
"kind": "definition"
},
{
"path": "types/node/util.d.ts",
"kind": "definition"
},
{
"path": "types/node/util/types.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/.eslintrc.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-eslintrcjson) (check: `rules`)"
},
{
"path": "types/node/v25/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/node/v25/assert.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/assert/strict.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/async_hooks.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/buffer.buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/child_process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/cluster.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/compatibility/iterators.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/console.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/constants.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/crypto.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/dgram.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/diagnostics_channel.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/dns.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/dns/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/domain.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/fs.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/fs/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/globals.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/globals.typedarray.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/http2.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/https.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/index.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/inspector.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/inspector.generated.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/inspector/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/net.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/node-tests-dom.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests-non-dom.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests-webworker.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/assert.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/async_hooks.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/buffer.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/child_process.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/cluster.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/console.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/constants.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/crypto.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/dgram.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/diagnostics_channel.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/dns.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/events-dom.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/events-maps.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/events-non-dom.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/events.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/fs.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/globals-dom.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/globals-non-dom.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/globals.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/http.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/http2.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/https.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/inspector.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/module.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/net.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/os.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/path.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/perf_hooks.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/process.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/querystring.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/quic.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/readline.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/repl.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/sea.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/sqlite.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/stream-web.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/stream.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/string_decoder.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/test.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/timers.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/timers_promises.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/tls.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/trace_events.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/tty.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/url.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/util.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/util_types.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/v8.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/vm.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/wasi.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/worker_threads.ts",
"kind": "test"
},
{
"path": "types/node/v25/node-tests/zlib.ts",
"kind": "test"
},
{
"path": "types/node/v25/os.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/v25/path.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/path/posix.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/path/win32.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/perf_hooks.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/punycode.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/querystring.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/quic.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/readline.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/readline/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/repl.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/sea.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/sqlite.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/stream/consumers.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/stream/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/stream/web.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/string_decoder.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/test/reporters.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/timers.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/timers/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/tls.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/trace_events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/ts5.6/buffer.buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/ts5.6/compatibility/float16array.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/ts5.6/globals.typedarray.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/ts5.6/index.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/ts5.6/tsconfig.dom.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.target`, `compilerOptions.exactOptionalPropertyTypes`)"
},
{
"path": "types/node/v25/ts5.6/tsconfig.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.target`, `compilerOptions.exactOptionalPropertyTypes`)"
},
{
"path": "types/node/v25/ts5.6/tsconfig.non-dom.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.target`, `compilerOptions.exactOptionalPropertyTypes`)"
},
{
"path": "types/node/v25/ts5.6/tsconfig.webworker.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.lib.1`, `compilerOptions.target`, `compilerOptions.exactOptionalPropertyTypes`)"
},
{
"path": "types/node/v25/ts5.7/compatibility/float16array.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/ts5.7/index.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/ts5.7/tsconfig.dom.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.target`, `compilerOptions.exactOptionalPropertyTypes`)"
},
{
"path": "types/node/v25/ts5.7/tsconfig.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.target`, `compilerOptions.exactOptionalPropertyTypes`)"
},
{
"path": "types/node/v25/ts5.7/tsconfig.non-dom.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.target`, `compilerOptions.exactOptionalPropertyTypes`)"
},
{
"path": "types/node/v25/ts5.7/tsconfig.webworker.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.lib.1`, `compilerOptions.target`, `compilerOptions.exactOptionalPropertyTypes`)"
},
{
"path": "types/node/v25/tsconfig.dom.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.target`, `compilerOptions.exactOptionalPropertyTypes`, `compilerOptions.esModuleInterop`)"
},
{
"path": "types/node/v25/tsconfig.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.target`, `compilerOptions.exactOptionalPropertyTypes`, `compilerOptions.esModuleInterop`)"
},
{
"path": "types/node/v25/tsconfig.non-dom.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.target`, `compilerOptions.exactOptionalPropertyTypes`, `compilerOptions.esModuleInterop`)"
},
{
"path": "types/node/v25/tsconfig.webworker.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.lib.1`, `compilerOptions.target`, `compilerOptions.exactOptionalPropertyTypes`, `compilerOptions.esModuleInterop`)"
},
{
"path": "types/node/v25/tty.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/url.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/util.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/util/types.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/v8.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/vm.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/wasi.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/web-globals/abortcontroller.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/web-globals/blob.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/web-globals/console.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/web-globals/crypto.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/web-globals/domexception.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/web-globals/encoding.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/web-globals/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/web-globals/fetch.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/web-globals/importmeta.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/web-globals/messaging.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/web-globals/navigator.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/web-globals/performance.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/web-globals/storage.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/web-globals/streams.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/web-globals/timers.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/web-globals/url.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/worker_threads.d.ts",
"kind": "definition"
},
{
"path": "types/node/v25/zlib.d.ts",
"kind": "definition"
},
{
"path": "types/node/v8.d.ts",
"kind": "definition"
},
{
"path": "types/node/vm.d.ts",
"kind": "definition"
},
{
"path": "types/node/worker_threads.d.ts",
"kind": "definition"
},
{
"path": "types/node/zlib.d.ts",
"kind": "definition"
}
],
"owners": [
"Microsoft",
"jkomyno",
"r3nya",
"btoueg",
"touffy",
"mohsen1",
"galkin",
"eps1lon",
"WilcoBakker",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky",
"Renegade334",
"anonrig"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 4424829209,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/ba388b7c4d7fa37f0d3014b67bf7cc6320152033/checks?check_suite_id=68492221733"
} |
Contributor
|
🔔 @microsoft @jkomyno @r3nya @btoueg @Touffy @mohsen1 @galkin @eps1lon @WilcoBakker @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky @Renegade334 @anonrig — please review this PR in the next few days. Be sure to explicitly select |
Contributor
|
@hitsthings Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
- Bump version to 26.0.9999 with undici-types ~8.2.0 - Create v25 backward-compat snapshot - Add printf-style messages to assert methods (v26.0.0) - Add raw key format support to crypto KeyObject APIs (v26.0.0) - Deprecate module.register() in favor of registerHooks (v26.0.0) - Update documentation URLs from v25 to v26
Author
|
Hmm, I suspect my merge conflict resolution is borked since I copied v25 into a folder. I will have to recopy that folder. |
Contributor
|
Thanks for the contribution. Because of the nature of DT branches, we need to merge the remaining v25.x version updates before branching, and then there are a few more steps involved in actually cutting the new major release, including adding some pending major type-only changes. |
Contributor
|
@hitsthings The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
Author
Makes sense. Let me know what actions you need from me, if any. I can see the issue I mentioned in the PR description causes a CI failure, if nothing else - https://github.com/DefinitelyTyped/DefinitelyTyped/actions/runs/25695338058/job/75442275207 If you're happy to (eventually) continue with this PR, then I can do the suggested change to fix that: |
Contributor
|
Thanks. What I suggest, if it's OK with you, is that this gets marked as a draft for now, then once the root (ie. v25.x) branch is up to speed then we will cut the new branch at that point. Would probably be easier if the actual PR is managed by a maintainer, but would be useful to bring in some of the work you've done, if you're happy to be pinged then? (For interest, the CI issue is from an undici snafu.) |
Contributor
|
@hitsthings The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking for types and didn't see a PR yet. For transparency, Claude did the bulk of work, with some interaction and guidance. Given it's likely a high impact project, feel free to reject it if you have your own processes for this one! Totally understandable. I believe all readme steps were followed and happy to tweak.
Didn't add Temporal as my understanding is that comes from the lib.es*.d.ts instead.
I noticed an error with
pnpm test node, but it's preexisting:Claude thinks it's fixable by modifying
types/node/node-tests/buffer.tsBut I figure maybe there is something else going on and I don't have context? I can make that change if there's no reason not to.
pnpm test node.If changing an existing definition:
package.json.