Skip to content

[react] add missing undefined to fetchPriority#74979

Open
gineika wants to merge 1 commit into
DefinitelyTyped:masterfrom
gineika:img-fetchpriority
Open

[react] add missing undefined to fetchPriority#74979
gineika wants to merge 1 commit into
DefinitelyTyped:masterfrom
gineika:img-fetchpriority

Conversation

@gineika
Copy link
Copy Markdown

@gineika gineika commented May 11, 2026

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 11, 2026 •
edited
Loading

@gineika Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 74979,
  "author": "gineika",
  "headCommitOid": "a01c4d93cff870a288494ef06ed89d0ebebb50ff",
  "mergeBaseOid": "84efd8820459db1cdaad122f2347683b7db023ee",
  "lastPushDate": "2026-05-11T11:34:38.000Z",
  "lastActivityDate": "2026-05-11T13:44:35.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/ts5.0/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v15/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v16/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v17/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v18/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v18/ts5.0/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "priyanshurav",
        "Semigradsky",
        "mattpocock"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "priyanshurav",
      "date": "2026-05-11T13:44:35.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 4420300360,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Untested Change This PR does not touch tests labels May 11, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 11, 2026

Hey @gineika,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board May 11, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 11, 2026

🔔 @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @eps1lon @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @priyanshurav @Semigradsky @mattpocock — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board May 11, 2026
priyanshurav
priyanshurav reviewed May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@priyanshurav priyanshurav left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retracted: I initially overlooked the exactOptionalPropertyTypes constraint.

priyanshurav
priyanshurav approved these changes May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@priyanshurav priyanshurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnnyreilly johnnyreilly Awaiting requested review from johnnyreilly johnnyreilly is a code owner

@Jessidhia Jessidhia Awaiting requested review from Jessidhia Jessidhia is a code owner

@eps1lon eps1lon Awaiting requested review from eps1lon eps1lon is a code owner

1 more reviewer

@priyanshurav priyanshurav priyanshurav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Critical package Owner Approved A listed owner of this package signed off on the pull request. Untested Change This PR does not touch tests

Projects

Pull Request Status Board
Status: Needs Maintainer Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gineika @typescript-bot @priyanshurav