Skip to content

[fancytree] include missing type declarations from source#74972

Open
daberni wants to merge 2 commits into
DefinitelyTyped:masterfrom
daberni:fancytree
Open

[fancytree] include missing type declarations from source#74972
daberni wants to merge 2 commits into
DefinitelyTyped:masterfrom
daberni:fancytree

Conversation

@daberni
Copy link
Copy Markdown
Contributor

@daberni daberni commented May 9, 2026

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change.
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run pnpm test <package to test>.
  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/mar10/fancytree
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 9, 2026

@daberni Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74972,
  "author": "daberni",
  "headCommitOid": "1ff89725b3ea72781fe94459636d0f246afb84f2",
  "mergeBaseOid": "fc6745acb34316f0644022877c54c578d88ecd64",
  "lastPushDate": "2026-05-09T12:31:47.000Z",
  "lastActivityDate": "2026-05-09T12:31:47.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "jquery.fancytree",
      "kind": "edit",
      "files": [
        {
          "path": "types/jquery.fancytree/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/jquery.fancytree/jquery.fancytree-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/jquery.fancytree/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "alphaleonis",
        "itsmattius",
        "niikoo",
        "Nitecube",
        "hosni"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 4412526560,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @alphaleonis @itsmattius @niikoo @Nitecube @hosni — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting for Code Reviews

Development

Successfully merging this pull request may close these issues.

2 participants