Skip to content

[chrome] remove type deprecations, remove NoInferX and unexpose _debugger namespace#74965

Draft
erwanjugand wants to merge 1 commit into
DefinitelyTyped:masterfrom
erwanjugand:0.2.x
Draft

[chrome] remove type deprecations, remove NoInferX and unexpose _debugger namespace#74965
erwanjugand wants to merge 1 commit into
DefinitelyTyped:masterfrom
erwanjugand:0.2.x

Conversation

@erwanjugand
Copy link
Copy Markdown
Contributor

@erwanjugand erwanjugand commented May 7, 2026

Please fill in this template.

Potential Breaking Change:

  • Removed deprecated types :
    • ManifestPermissions (use ManifestPermission instead for consistency)
    • ManifestOptionalPermissions (use ManifestOptionalPermission instead for consistency)
    • ProcessorUsage (use the documented ISO alias CpuTime instead)
    • VpnSessionParameters (use the documented ISO alias Parameters instead)
  • Remove exposed _debugger namespace (use debugger namespace instead)
  • Removed internal NoInferX in favor of the native TypeScript NoInfer utility type. (Required TypeScript 5.4 or later)

🚨 Pending the end of TypeScript 5.3 support by @definitelytyped/typescript-packages. 🚨

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 7, 2026

@erwanjugand Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have failed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74965,
  "author": "erwanjugand",
  "headCommitOid": "38dff7c482166a6887a618b3b2e881b134e05432",
  "mergeBaseOid": "ccb9c81c240f22ff75fe60a036c3870bf4fb78fa",
  "lastPushDate": "2026-05-07T16:33:58.000Z",
  "lastActivityDate": "2026-05-07T16:41:36.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "chrome",
      "kind": "edit",
      "files": [
        {
          "path": "types/chrome/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/chrome/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/chrome/test/index.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "matthewkimber",
        "otiai10",
        "sreimer15",
        "MatCarlson",
        "ekinsol",
        "echoabstract",
        "spasma",
        "bdbai",
        "JasonXian",
        "usertim",
        "idan315",
        "nicolas377",
        "idosal",
        "fregante",
        "erwanjugand"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 4399039214,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/38dff7c482166a6887a618b3b2e881b134e05432/checks?check_suite_id=67942260730"
}

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels May 7, 2026
@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board May 7, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @matthewkimber @otiai10 @sreimer15 @matcarlson @ekinsol @EchoAbstract @spasma @bdbai @JasonXian @userTim @idan315 @nicolas377 @idosal @fregante — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label May 7, 2026
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in Pull Request Status Board May 7, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

@erwanjugand The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label May 7, 2026
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board May 7, 2026
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label May 7, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

@erwanjugand The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in Pull Request Status Board May 7, 2026
@erwanjugand erwanjugand marked this pull request as draft May 7, 2026 16:48
@erwanjugand erwanjugand changed the title [chrome] drop support for TypeScript 5.3 and below, remove type deprecations and unexpose _debugger namespace [chrome] remove type deprecations, remove NoInferX and unexpose _debugger namespace May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Critical package The CI failed When GH Actions fails

Projects

Status: Needs Author Action

Development

Successfully merging this pull request may close these issues.

2 participants