Add credentials fields to chrome.cast.media.LoadRequest for Cast Connect / Android TV usage by CHENPINCHIEH · Pull Request #74959 · DefinitelyTyped/DefinitelyTyped

CHENPINCHIEH · 2026-05-06T09:02:00Z

This PR adds missing credential-related fields to chrome.cast.media.LoadRequest in @types/chrome.

Context

In real-world Google Cast applications, launch and session identity information is propagated across different platforms (Web, Chromecast, and Android TV via Cast Connect).

While the official Cast SDK documentation does not explicitly define these as formal LoadRequest properties, they are used in practice as part of Cast Connect / Android TV launch data handling.

Changes

Added optional fields to LoadRequest:

credentials
credentialsType
atvCredentials
atvCredentialsType

These fields represent:

Generic Cast session credentials (Web / Chromecast)
Platform-specific override for Android TV (Cast Connect)

Rationale

Cast launch data is passed as opaque JSON and consumed by receiver applications.
Android TV (Cast Connect) implementations may differentiate authentication/identity data from generic Cast receivers.
These fields reflect an existing runtime pattern used in Cast Connect-based applications.

Notes

No changes to existing runtime behavior
All fields are optional and non-breaking
No modification to constructor or class implementation
Only type augmentation of existing LoadRequest

Test

Added type tests verifying:

LoadRequest accepts new credential fields
No breaking changes to existing media loading API

Add Credentials fields to LoadRequest

Fix update chrome FileSystem types to match dtslint expectations

typescript-bot · 2026-05-06T09:02:40Z

@CHENPINCHIEH Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

1 package in this PR (and infra files)

chrome — on npm, on unpkg
Infra files
- package.json

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

❌ No merge conflicts
✅ Continuous integration tests have passed
🕐 A DT maintainer needs to approve changes that affect DT infrastructure (package.json)

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 74959,
  "author": "CHENPINCHIEH",
  "headCommitOid": "391a1d886d71a244498d22106ba959ada7ddb5e1",
  "mergeBaseOid": "5afdcf191470cfb4efc44ff12fe66231ca64f1d9",
  "lastPushDate": "2026-05-06T09:02:00.000Z",
  "lastActivityDate": "2026-05-08T08:36:24.000Z",
  "hasMergeConflict": true,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "package.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical",
      "isSafeInfrastructureEdit": false
    },
    {
      "name": "chrome",
      "kind": "edit",
      "files": [
        {
          "path": "types/chrome/chrome-cast/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/chrome/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/chrome/test/chrome-cast.ts",
          "kind": "test"
        },
        {
          "path": "types/chrome/test/index.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "matthewkimber",
        "otiai10",
        "sreimer15",
        "MatCarlson",
        "ekinsol",
        "echoabstract",
        "spasma",
        "bdbai",
        "JasonXian",
        "usertim",
        "idan315",
        "nicolas377",
        "idosal",
        "fregante",
        "erwanjugand"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "erwanjugand",
      "date": "2026-05-08T08:36:24.000Z"
    }
  ],
  "mainBotCommentID": 4386520490,
  "ciResult": "pass"
}

typescript-bot · 2026-05-06T09:02:42Z

🔔 @matthewkimber @otiai10 @sreimer15 @matcarlson @ekinsol @EchoAbstract @spasma @bdbai @JasonXian @userTim @idan315 @nicolas377 @idosal @fregante @erwanjugand — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

DangerBotOSS · 2026-05-06T09:06:51Z

Formatting

The following files are not formatted:

types/chrome/index.d.ts
types/chrome/test/chrome-cast.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against 391a1d8

erwanjugand

Hi, this PR introduces changes that, in my opinion, shouldn’t be included (impact on Chrome extension types, infrastructure changes).

Also, how can your changes be tested?
I don’t understand why the Chromecast types are included here and how to test this.

typescript-bot · 2026-05-06T11:13:34Z

@CHENPINCHIEH One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

typescript-bot · 2026-05-07T13:16:25Z

@CHENPINCHIEH Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

CHENPINCHIEH · 2026-05-08T03:19:52Z

chrome.cast.media.LoadRequest

LoadRequest
Hi @erwanjugand

To clarify, I am currently developing/updating the sender side.

The reason this PR affects Chrome extension types is that the fields I'm adding are officially defined under chrome.cast.media.LoadRequest according to the Google Cast Official Documentation.

Since the cast-sender implementation directly inherits or references these types from the Chrome extension namespace, updating chrome.cast is a necessary step to ensure the sender-side types remain accurate and functional.

erwanjugand · 2026-05-08T08:13:54Z

        "remark-validate-links": "^13.0.0",
        "risk": "^0.0.4",
-        "typescript": "next"
+        "typescript": "^5.9.3"


You shouldn't modify the repository's package.json

erwanjugand · 2026-05-08T08:16:18Z

@@ -1,4 +1,3 @@
-/// <reference types="filesystem" />


The PR should only modify chrome-cast, not the types and tests related to Chrome extensions.

erwanjugand · 2026-05-08T08:19:35Z

            playbackRate?: number | undefined;
        }

+        interface LoadRequest {


I think this should be in the LoadRequest class.

Missing queueData, requestId, sessionId and type keys ?

erwanjugand · 2026-05-08T08:25:25Z

+    loadRequest.credentials = 'user-123';
+    loadRequest.credentialsType = 'token';
+    loadRequest.atvCredentials = 'user-123-atv';
+    loadRequest.atvCredentialsType = 'token';


Suggested change

loadRequest.credentials = 'user-123';

loadRequest.credentialsType = 'token';

loadRequest.atvCredentials = 'user-123-atv';

loadRequest.atvCredentialsType = 'token';

loadRequest.credentials = 'user-123'; // $ExpectType string | undefined

loadRequest.credentialsType = 'token'; // $ExpectType string | undefined

loadRequest.atvCredentials = 'user-123-atv'; // $ExpectType string | undefined

loadRequest.atvCredentialsType = 'token'; // $ExpectType string | undefined

Confirm that the values can be undefined.

erwanjugand · 2026-05-08T08:33:36Z

+            credentials?: string;
+            credentialsType?: string;
+            atvCredentials?: string;
+            atvCredentialsType?: string;


Suggested change

credentials?: string;

credentialsType?: string;

atvCredentials?: string;

atvCredentialsType?: string;

credentials?: string | undefined;

credentialsType?: string | undefined;

atvCredentials?: string | undefined;

atvCredentialsType?: string | undefined;

If we can explicitly define undefined with exactOptionalPropertyTypes option

CHENPINCHIEH added 2 commits May 6, 2026 16:46

Add Credentials fields to LoadRequest

c7e1b40

Add Credentials fields to LoadRequest

Fix update chrome FileSystem types to match dtslint expectations

391a1d8

Fix update chrome FileSystem types to match dtslint expectations

typescript-bot added Critical package Edits Infrastructure labels May 6, 2026

typescript-bot added this to Pull Request Status Board May 6, 2026

typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board May 6, 2026

typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board May 6, 2026

erwanjugand suggested changes May 6, 2026

View reviewed changes

typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 6, 2026

typescript-bot moved this from Needs Maintainer Action to Needs Author Action in Pull Request Status Board May 6, 2026

typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label May 7, 2026

erwanjugand suggested changes May 8, 2026

View reviewed changes

Conversation

CHENPINCHIEH commented May 6, 2026

Context

Changes

Rationale

Notes

Test

Uh oh!

typescript-bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1 package in this PR (and infra files)

Code Reviews

Status

Uh oh!

typescript-bot commented May 6, 2026

Uh oh!

DangerBotOSS commented May 6, 2026

Formatting

Uh oh!

erwanjugand left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented May 6, 2026

Uh oh!

typescript-bot commented May 7, 2026

Uh oh!

CHENPINCHIEH commented May 8, 2026

Uh oh!

erwanjugand May 8, 2026

Choose a reason for hiding this comment

Uh oh!

erwanjugand May 8, 2026

Choose a reason for hiding this comment

Uh oh!

erwanjugand May 8, 2026

Choose a reason for hiding this comment

Uh oh!

erwanjugand May 8, 2026

Choose a reason for hiding this comment

Uh oh!

erwanjugand May 8, 2026

Choose a reason for hiding this comment

Uh oh!

erwanjugand May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

typescript-bot commented May 6, 2026 •

edited

Loading

erwanjugand left a comment •

edited

Loading