Skip to content

Add 3 missing fields to google-apps-script drive_v2 Permission interface#74949

Open
thromer wants to merge 1 commit into
DefinitelyTyped:masterfrom
thromer:patch-1
Open

Add 3 missing fields to google-apps-script drive_v2 Permission interface#74949
thromer wants to merge 1 commit into
DefinitelyTyped:masterfrom
thromer:patch-1

Conversation

@thromer
Copy link
Copy Markdown

@thromer thromer commented May 3, 2026

Reference: https://developers.google.com/workspace/drive/api/reference/rest/v2/permissions#Permission

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json -- not applicable.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 3, 2026

@thromer Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 8 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74949,
  "author": "thromer",
  "headCommitOid": "8fc2068b6beca7ef8ffff88c619f1c24d7974617",
  "mergeBaseOid": "52ce0fc2ae2a9fb77656b929e34312a21a864bec",
  "lastPushDate": "2026-05-03T01:52:40.000Z",
  "lastActivityDate": "2026-05-03T01:52:40.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "google-apps-script",
      "kind": "edit",
      "files": [
        {
          "path": "types/google-apps-script/apis/drive_v2.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jpoehnelt",
        "sqrrrl",
        "PierrickVoulet",
        "vinay-google"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 4365158713,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels May 3, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

Hey @thromer,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board May 3, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @jpoehnelt @sqrrrl @PierrickVoulet @vinay-google — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests

Projects

Status: Needs Maintainer Review

Development

Successfully merging this pull request may close these issues.

2 participants