[ms] Add type for generic string.#74936
Conversation
Allow for any string type that will return undefined if invalid.
|
@KeithBrown39423 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 11 days. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74936,
"author": "KeithBrown39423",
"headCommitOid": "2bbf65de8297058fc02cb92e29c26c0ee25a5d1f",
"mergeBaseOid": "de9d7a2a0f0fa222ad71babffd3144df176d3410",
"lastPushDate": "2026-04-30T12:01:33.000Z",
"lastActivityDate": "2026-04-30T12:01:33.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "ms",
"kind": "edit",
"files": [
{
"path": "types/ms/index.d.ts",
"kind": "definition"
},
{
"path": "types/ms/ms-tests.ts",
"kind": "test"
}
],
"owners": [
"danny8002"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 4352271092,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/2bbf65de8297058fc02cb92e29c26c0ee25a5d1f/checks?check_suite_id=66888194598"
} |
|
🔔 @danny8002 — please review this PR in the next few days. Be sure to explicitly select |
|
@KeithBrown39423 The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
Allow for any string type that will return undefined if invalid.
Please fill in this template.
pnpm test <package to test>.If changing an existing definition:
package.json.