[node] Add webcrypto generateKey types for Ed25519, Ed448, X25519, and X448#74848
[node] Add webcrypto generateKey types for Ed25519, Ed448, X25519, and X448#74848heskew wants to merge 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@heskew Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 14 days. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74848,
"author": "heskew",
"headCommitOid": "e3625a8f707c8056ce92c2f882a5cb49d6b7c8a4",
"mergeBaseOid": "a7251fc4f5a9f005b3c0b6e19dd931e90b0aa223",
"lastPushDate": "2026-04-05T14:00:48.000Z",
"lastActivityDate": "2026-04-05T14:31:09.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/crypto.d.ts",
"kind": "definition"
},
{
"path": "types/node/node-tests/crypto.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"jkomyno",
"r3nya",
"btoueg",
"touffy",
"mohsen1",
"galkin",
"eps1lon",
"WilcoBakker",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky",
"Renegade334",
"anonrig"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "changereq",
"reviewer": "Renegade334",
"date": "2026-04-05T14:31:09.000Z"
}
],
"mainBotCommentID": 4188935858,
"ciResult": "pass"
} |
|
🔔 @microsoft @jkomyno @r3nya @btoueg @Touffy @mohsen1 @galkin @eps1lon @WilcoBakker @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky @Renegade334 @anonrig — please review this PR in the next few days. Be sure to explicitly select |
Renegade334
left a comment
There was a problem hiding this comment.
Duplicate of #73066, deliberately blocking on microsoft/TypeScript-DOM-lib-generator#2050 so that we don't end up diverging.
|
@heskew One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
Please fill in this template.
Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run
pnpm test <package to test>.Provide a URL to documentation or source code which provides context for the suggested changes: https://nodejs.org/api/webcrypto.html#subtlegeneratekeyalgorithm-extractable-keyusages
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the
package.json. (not needed)