@sudarshan12s Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

• oracledb — on npm, on unpkg (author is owner)
  • owner-approval: @sharadraju

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 74833,
  "author": "sudarshan12s",
  "headCommitOid": "0760be2912c3a881a3d9a459318d7f54bec2c876",
  "mergeBaseOid": "8fe0c8af85c80359cf96a19fb00e423332cf700f",
  "lastPushDate": "2026-04-03T06:45:15.000Z",
  "lastActivityDate": "2026-04-14T16:10:58.000Z",
  "mergeOfferDate": "2026-04-14T15:29:17.000Z",
  "mergeRequestDate": "2026-04-14T16:10:58.000Z",
  "mergeRequestUser": "sudarshan12s",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "oracledb",
      "kind": "edit",
      "files": [
        {
          "path": "types/oracledb/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oracledb/oracledb-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "connorjayfitzgerald",
        "dannyb648",
        "jacobwheale",
        "sudarshan12s",
        "sharadraju"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "RyanCavanaugh",
      "date": "2026-04-14T15:28:32.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "sharadraju",
      "date": "2026-04-14T08:01:30.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 4182178808,
  "ciResult": "pass"
}

🔔 @connorjayfitzgerald @dannyb648 @jacobwheale @sharadraju — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@sudarshan12s One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

Typically someone using an optional parameter in a callback position is mistakenly thinking that it means "is allowed to be ignored by the callee", not "is allowed to be unprovided by the caller". It'd be clearer if all these used | undefined instead.

Thanks @RyanCavanaugh . If I understand correctly, you're suggesting changing the callback to:

function createPool(poolAttributes: PoolAttributes, callback: (error: DBError | null , pool: Pool | undefined) => void): void;

node-oracledb driver on error invokes the callback with a single argument: (second arg is not sent or remains optional)
callback(error)

on Success with 2 args:
callback(null, pool)

Let me know if I should prefer the stricter (pool: Pool | undefined) for consistency.

For that case you can use a spread tuple:

function foo(cb: (...args: [string] | [null, Error]) => void) {

For that case you can use a spread tuple:

function foo(cb: (...args: [string] | [null, Error]) => void) {

If I use above syntax for:

function createPool(poolAttributes: PoolAttributes, callback: (...args: [DBError] | [null, Pool]) => void): void;

I get the following lint error:

Type [T] is a single-element tuple type. You probably meant T[].eslint[@definitelytyped/no-single-element-tuple-type](https://github.com/microsoft/DefinitelyTyped-tools/tree/main/packages/eslint-plugin/docs/rules/no-single-element-tuple-type.md)
interface OracleDB.DBError

I can instead use:

interface ResultCallback<T> {
        (error: DBError): void;
        (error: null): void;
        (error: null, value: T): void;
    }

function createPool(poolAttributes: PoolAttributes, callback: ResultCallback<Pool>): void;

I can then use ResultCallback at all the places applicable (createLob(type: DbType, callback: ResultCallback<Lob>): void; ,... ) . The second one, (error: null): void; is added as there are few cases like for streaming lob write , where we just use cb(null).

Does this approach look reasonable?

Thanks.

You should suppress that lint warning, it's a false positive

@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

You should suppress that lint warning, it's a false positive

Thanks. I have suppressed the warning and made changes , can you take a look ..

// eslint-disable-next-line @definitelytyped/no-single-element-tuple-type
    type ResultCallback<T> = (...args: [DBError] | [null, T]) => void;

Re-ping @connorjayfitzgerald, @dannyb648, @jacobwheale:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@sudarshan12s: Everything looks good here. I am ready to merge this PR (at 0760be2) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@connorjayfitzgerald, @dannyb648, @jacobwheale, @sharadraju: you can do this too.)

Ready to merge