[steamcommunity] Add asset_properties to CEconItem #74828
[steamcommunity] Add asset_properties to CEconItem #74828kjljxybr wants to merge 4 commits intoDefinitelyTyped:masterfrom
Conversation
|
@kjljxybr Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74828,
"author": "kjljxybr",
"headCommitOid": "0832fc6ad969934be26a5fc5450255b8711ac016",
"mergeBaseOid": "8fe0c8af85c80359cf96a19fb00e423332cf700f",
"lastPushDate": "2026-04-02T12:50:42.000Z",
"lastActivityDate": "2026-04-13T21:04:59.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "steamcommunity",
"kind": "edit",
"files": [
{
"path": "types/steamcommunity/classes/CEconItem.d.ts",
"kind": "definition"
},
{
"path": "types/steamcommunity/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"SenTisso"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "changereq",
"reviewer": "sentisso",
"date": "2026-04-13T13:31:10.000Z"
}
],
"mainBotCommentID": 4177650306,
"ciResult": "pass"
} |
|
Hey @kjljxybr, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @sentisso — please review this PR in the next few days. Be sure to explicitly select |
|
@kjljxybr The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
…roved readability.
|
Re-ping @sentisso: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
| app_data?: any; | ||
| /** An array of objects containing the item's asset properties. These are not always present, and their contents are entirely arbitrary and up to the game. */ asset_properties?: | ||
| Array< | ||
| & { propertyid: number; name: string } |
There was a problem hiding this comment.
Correct me if I'm wrong, but is the name always present?
I tested it with dev tools on a cs2 inventory page (/730/2?l=english&count=75&preserve_bbcode=1&raw_asset_properties=1) and I don't see the name, only propertyid and the other value properties, see:
There was a problem hiding this comment.
I was using this description to update typings
There was a problem hiding this comment.
Right, so you're also not sure if the name is always there? To be safe, I'd make the name property optional.
|
@kjljxybr One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.