Skip to content

Feature/mapping editor#74818

Merged
typescript-bot merged 16 commits intoDefinitelyTyped:masterfrom
ujam-dev:feature/mapping-editor
Apr 17, 2026
Merged

Feature/mapping editor#74818
typescript-bot merged 16 commits intoDefinitelyTyped:masterfrom
ujam-dev:feature/mapping-editor

Conversation

@agachuma
Copy link
Copy Markdown
Contributor

@agachuma agachuma commented Mar 31, 2026

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

UJAM-JH and others added 16 commits August 14, 2025 10:34
@UJAM-JH @agachuma
fixed test errors
7e5f8a6
@UJAM-JH @agachuma
fix test errors
33bc089
@pkellett @agachuma
added LoadInstrumentFromFile to docs
2cdd766
@agachuma
fixing conflicts
5131c54
@pkellett @agachuma
added getValueFromTOC() to docs
470239d
@agachuma
Fixing conflicts
6681ec5 
Fixing conflicts

fixing conflicts

fixing conflitcs
@agachuma
added path and name and removed parentPath
7725125 
fixing conflict
fixing conflictss

fixing conflicts

fixing conflicts

fixing conflicts

fixing conflicts
@agachuma
Added selectAllZones and deselectAllZones functions
01be460 
fixing conflicts
@agachuma
Adding clickable capability
bfd34c1
@agachuma
Adding selectZone function
1b45c3a 
fixing conflicts

fixing conflicts

fixing conflicts
@agachuma
changed selectZone to selectZones
8ee0ab4
@agachuma
Added vertical and horizontal zoom
270050c
@agachuma
changing addZone and removeZone to addZones and removeZones
f12a7b7
@agachuma
Added replace moduleAtPath
215e655
@agachuma
Merge branch 'DefinitelyTyped:master' into feature/mapping-editor
1585c0d
@agachuma
Adding SliceEditor changes
69157b8
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 31, 2026 •
edited
Loading

@agachuma Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 74818,
  "author": "agachuma",
  "headCommitOid": "69157b862ed798a66fd769a44c7d768ebc0b1902",
  "mergeBaseOid": "dded1f2e5f8575098e7b74f4f9f50fd504017614",
  "lastPushDate": "2026-03-31T12:44:45.000Z",
  "lastActivityDate": "2026-04-17T09:42:13.000Z",
  "mergeOfferDate": "2026-04-16T15:33:35.000Z",
  "mergeRequestDate": "2026-04-17T09:42:13.000Z",
  "mergeRequestUser": "agachuma",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "gorilla-engine",
      "kind": "edit",
      "files": [
        {
          "path": "types/gorilla-engine/components/MappingEditor.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gorilla-engine/components/SliceEditor.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gorilla-engine/gorilla-engine-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/gorilla-engine/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jhwoodward",
        "UJAM-JH",
        "rip-off-hb",
        "pkellett",
        "vpietropaolo-ujam",
        "agachuma"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rip-off-hb",
      "date": "2026-04-16T15:32:52.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 4162389494,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Author is Owner The author of this PR is a listed owner of the package. label Mar 31, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 31, 2026

🔔 @jhwoodward @UJAM-JH @rip-off-hb @pkellett @vpietropaolo-ujam — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Mar 31, 2026
@DangerBotOSS
Copy link
Copy Markdown

DangerBotOSS commented Mar 31, 2026

Formatting

The following files are not formatted:

  1. types/gorilla-engine/gorilla-engine-tests.ts
  2. types/gorilla-engine/components/MappingEditor.d.ts
  3. types/gorilla-engine/index.d.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against 69157b8

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 11, 2026

Re-ping @jhwoodward, @UJAM-JH, @rip-off-hb, @pkellett, @vpietropaolo-ujam:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Apr 11, 2026
rip-off-hb
rip-off-hb approved these changes Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown

@rip-off-hb rip-off-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No obvious issues!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Apr 16, 2026
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board Apr 16, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 16, 2026

@agachuma: Everything looks good here. I am ready to merge this PR (at 69157b8) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@jhwoodward, @UJAM-JH, @rip-off-hb, @pkellett, @vpietropaolo-ujam: you can do this too.)

@agachuma
Copy link
Copy Markdown
Contributor Author

agachuma commented Apr 17, 2026

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Apr 17, 2026
@typescript-bot typescript-bot merged commit 9ff61fe into DefinitelyTyped:master Apr 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rip-off-hb rip-off-hb rip-off-hb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

Pull Request Status Board
Status: Recently Merged

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@agachuma @typescript-bot @DangerBotOSS @rip-off-hb @UJAM-JH @pkellett