Skip to content

Updating type definitions for puppeteer-har#74777

Merged
typescript-bot merged 4 commits intoDefinitelyTyped:masterfrom
CaglarDeniz:master
Apr 10, 2026
Merged

Updating type definitions for puppeteer-har#74777
typescript-bot merged 4 commits intoDefinitelyTyped:masterfrom
CaglarDeniz:master

Conversation

@CaglarDeniz
Copy link
Copy Markdown
Contributor

If changing an existing definition:

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 18, 2026

@CaglarDeniz Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74777,
  "author": "CaglarDeniz",
  "headCommitOid": "4ca0cdb05ad629a256d3009e0d1192c33fb9af30",
  "mergeBaseOid": "b4043de9a862ce2e1eafc0ea0cd79e9b25972ed7",
  "lastPushDate": "2026-03-18T21:12:28.000Z",
  "lastActivityDate": "2026-04-10T20:23:59.000Z",
  "mergeOfferDate": "2026-04-08T20:16:45.000Z",
  "mergeRequestDate": "2026-04-10T20:23:59.000Z",
  "mergeRequestUser": "CaglarDeniz",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "puppeteer-har",
      "kind": "edit",
      "files": [
        {
          "path": "types/puppeteer-har/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/puppeteer-har/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/puppeteer-har/puppeteer-har-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "jordaz14"
      ],
      "addedOwners": [
        "CaglarDeniz"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "RyanCavanaugh",
      "date": "2026-04-08T20:16:03.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 4085612952,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Edits Owners This PR adds or removes owners label Mar 18, 2026
@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Mar 18, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @jordaz14 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Mar 18, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

@CaglarDeniz The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in Pull Request Status Board Mar 18, 2026
@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Mar 18, 2026
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board Mar 18, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

Re-ping @jordaz14:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Mar 30, 2026
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board Apr 6, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @CaglarDeniz.

(Ping @jordaz14.)

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Apr 8, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

@CaglarDeniz: Everything looks good here. I am ready to merge this PR (at 4ca0cdb) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@jordaz14: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in Pull Request Status Board Apr 8, 2026
@CaglarDeniz
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Apr 10, 2026
@typescript-bot typescript-bot merged commit 5f225ce into DefinitelyTyped:master Apr 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Edits Owners This PR adds or removes owners Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner

Projects

Status: Recently Merged

Development

Successfully merging this pull request may close these issues.

3 participants