[node-notifier] Align type definitions with v10 API surface#74675
[node-notifier] Align type definitions with v10 API surface#74675locactus wants to merge 1 commit intoDefinitelyTyped:masterfrom
Conversation
Signed-off-by: Osmond James <ossie@chickenmouse.com>
|
@locactus Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. InactiveThis PR has been inactive for 16 days — please merge or say something if there's a problem, otherwise it will be closed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74675,
"author": "locactus",
"headCommitOid": "012eda644f70680dfaa10b0783675095cb8bd023",
"mergeBaseOid": "1e61bc5e872ac817652ae8625a8d21abe8ba94fc",
"lastPushDate": "2026-03-11T19:58:52.000Z",
"lastActivityDate": "2026-04-02T22:34:31.000Z",
"mergeOfferDate": "2026-04-02T22:35:11.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "node-notifier",
"kind": "edit",
"files": [
{
"path": "types/node-notifier/index.d.ts",
"kind": "definition"
},
{
"path": "types/node-notifier/node-notifier-tests.ts",
"kind": "test"
},
{
"path": "types/node-notifier/notifiers/balloon.d.ts",
"kind": "definition"
},
{
"path": "types/node-notifier/notifiers/growl.d.ts",
"kind": "definition"
},
{
"path": "types/node-notifier/notifiers/notificationcenter.d.ts",
"kind": "definition"
},
{
"path": "types/node-notifier/notifiers/notifysend.d.ts",
"kind": "definition"
},
{
"path": "types/node-notifier/notifiers/toaster.d.ts",
"kind": "definition"
}
],
"owners": [
"tkQubo",
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "RyanCavanaugh",
"date": "2026-04-02T22:34:31.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 4041837228,
"ciResult": "pass"
} |
|
🔔 @tkqubo @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select |
|
Re-ping @tkqubo, @peterblazejewicz: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @locactus. (Ping @tkqubo, @peterblazejewicz.) |
|
@locactus: Everything looks good here. I am ready to merge this PR (at 012eda6) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@tkqubo, @peterblazejewicz: you can do this too.) |
|
Re-ping @locactus / @tkqubo, @peterblazejewicz: This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on May 2nd (in three weeks) if this doesn't happen. (If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.) |
Aligns @types/node-notifier with the v10.0.1 npm package: