[react-native-web] Update accessibilityRole values and add userSelect style for RN 0.83#74673
[react-native-web] Update accessibilityRole values and add userSelect style for RN 0.83#74673war-in wants to merge 3 commits intoDefinitelyTyped:masterfrom
Conversation
|
@war-in Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 31 days — it is considered abandoned, and therefore closed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74673,
"author": "war-in",
"headCommitOid": "72eda41ea0ecd40ac3fd0b93f1acf78460689c7c",
"mergeBaseOid": "1e61bc5e872ac817652ae8625a8d21abe8ba94fc",
"lastPushDate": "2026-03-11T15:14:47.000Z",
"lastActivityDate": "2026-03-17T16:20:26.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "react-native-web",
"kind": "edit",
"files": [
{
"path": "types/react-native-web/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-native-web/react-native-web-tests.tsx",
"kind": "test"
}
],
"owners": [
"fabioh8010",
"blazejkustra"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "changereq",
"reviewer": "blazejkustra",
"date": "2026-03-17T16:20:26.000Z"
}
],
"mainBotCommentID": 4074153334,
"ciResult": "pass"
} |
|
🔔 @fabioh8010 @blazejkustra — please review this PR in the next few days. Be sure to explicitly select |
blazejkustra
left a comment
There was a problem hiding this comment.
Overall looks good! Could you change the version of the package so it is compatible with the newest RNW release?
|
@war-in One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@war-in I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Apr 16th (in a week) if the issues aren't addressed. |
|
@war-in To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you! |
Please fill in this template.
pnpm test <package to test>.If changing an existing definition:
accessibilityRole: https://github.com/facebook/react-native/blob/v0.83.0/packages/react-native/Libraries/Components/View/ViewAccessibility.js#L14userSelect: https://github.com/facebook/react-native/blob/v0.83.0/packages/react-native/Libraries/StyleSheet/StyleSheetTypes.d.ts#L549package.json.