fix(node): align behavior of it and test#65511
fix(node): align behavior of it and test#65511typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@antongolub Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 65511,
"author": "antongolub",
"headCommitOid": "239da3237297ee7b619d77d63bb8e3d0f0be60c4",
"mergeBaseOid": "7ce9fe81aeb226b0fda1c43495df95d6ce340513",
"lastPushDate": "2023-05-16T17:58:16.000Z",
"lastActivityDate": "2023-05-16T18:54:29.000Z",
"mergeOfferDate": "2023-05-16T18:38:01.000Z",
"mergeRequestDate": "2023-05-16T18:54:29.000Z",
"mergeRequestUser": "antongolub",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/test.ts",
"kind": "test"
},
{
"path": "types/node/v18/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/test/test.ts",
"kind": "test"
},
{
"path": "types/node/v18/ts4.8/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/test/test.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"DefinitelyTyped",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"n-e",
"galkin",
"parambirs",
"eps1lon",
"SimonSchick",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2023-05-16T18:37:15.000Z",
"isMaintainer": true
},
{
"type": "stale",
"reviewer": "Semigradsky",
"date": "2023-05-16T16:45:41.000Z",
"abbrOid": "8212abd"
}
],
"mainBotCommentID": 1549942778,
"ciResult": "pass"
} |
|
🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
|
@antongolub The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
99f286a to
8212abd
Compare
|
@antongolub The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
8212abd to
239da32
Compare
|
@Semigradsky Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@antongolub: Everything looks good here. I am ready to merge this PR (at 239da32) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: you can do this too.) |
|
Ready to merge |
nodejs/node#46889
https://nodejs.org/en/blog/release/v18.16.0
https://nodejs.org/en/blog/release/v19.8.0
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition: