[node] add EventEmitter.setMaxListeners static method#58205
[node] add EventEmitter.setMaxListeners static method#58205gabritto merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
|
@ejose19 Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 8 days. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 58205,
"author": "ejose19",
"headCommitOid": "6e4e1fe0b7fbeac1841f7d0ffa18c1580d61c8d3",
"mergeBaseOid": "e8760f8b6a72d8853c43474c785b6c4b5a2b0c9b",
"lastPushDate": "2022-01-15T18:53:02.000Z",
"lastActivityDate": "2022-01-21T16:53:14.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/events.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"DefinitelyTyped",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"n-e",
"galkin",
"parambirs",
"eps1lon",
"westy92",
"SimonSchick",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"Ryan-Willpower",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "stale",
"reviewer": "SimonSchick",
"date": "2022-01-15T17:32:05.000Z",
"abbrOid": "e953586"
},
{
"type": "stale",
"reviewer": "peterblazejewicz",
"date": "2022-01-15T17:23:45.000Z",
"abbrOid": "e953586"
}
],
"mainBotCommentID": 1013689498,
"ciResult": "pass"
} |
|
🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @westy92 @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @Ryan-Willpower @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 — please review this PR in the next few days. Be sure to explicitly select |
|
@ejose19 The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
bb1aa4a to
e953586
Compare
| * @since v11.13.0, v10.16.0 | ||
| */ | ||
| static once(emitter: NodeEventTarget, eventName: string | symbol, options?: StaticEventEmitterOptions): Promise<any[]>; | ||
| static once( |
There was a problem hiding this comment.
Please refrain from making unrelated changes.
There was a problem hiding this comment.
Actually, that change is made by prettier, if these are not fixed, each contributor will have to manually revert every style fixes which adds a burden on contributing, I can revert if that's what you end deciding.
|
@ejose19 One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@SimonSchick, @peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@SimonSchick do the recent changes address your comments? |
…d#58205) * [node] add EventEmitter.setMaxListeners static method * [node]: apply review comments
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition: