@nitroin Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• mathjs — on npm, on unpkg
  • owner-approval: @OpportunityLiu

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes in this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 53121,
  "author": "nitroin",
  "headCommitOid": "22ddf123d10314035832ff330dbb4dea1089196a",
  "lastPushDate": "2021-05-20T17:01:32.000Z",
  "lastActivityDate": "2021-05-23T15:08:40.000Z",
  "mergeOfferDate": "2021-05-21T01:45:13.000Z",
  "mergeRequestDate": "2021-05-23T15:08:40.000Z",
  "mergeRequestUser": "nitroin",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "mathjs",
      "kind": "edit",
      "files": [
        {
          "path": "types/mathjs/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mathjs/mathjs-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "siavol",
        "andnp",
        "bradbesserman",
        "pawkrol",
        "charlee",
        "mark-wiemer",
        "OpportunityLiu"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "OpportunityLiu",
      "date": "2021-05-21T01:44:38.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 844899639,
  "ciResult": "pass"
}

🔔 @siavol @andnp @bradbesserman @pawkrol @charlee @mark-wiemer @OpportunityLiu — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@nitroin One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@nitroin The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@OpportunityLiu Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@nitroin Everything looks good here. Great job! I am ready to merge this PR (at 22ddf12) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@siavol, @andnp, @bradbesserman, @pawkrol, @charlee, @mark-wiemer, @OpportunityLiu: you can do this too.)

Ready to merge

I just published @types/mathjs@9.3.1 to npm.