[node] Sync v8 and v9#24852
Merged
Merged
Conversation
Contributor
|
@Flarna Thank you for submitting this PR! 🔔 @parambirs @tellnes @WilcoBakker @octo-sniffle @smac89 @mwiktorczyk @wwwy3y3 @DeividasBakanas @kjin @alvis @OliverJAsh @eps1lon @Hannes-Magnusson-CK @jkomyno @hoo29 @n-e @ajafff - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
Contributor
Author
|
CI fail seems to be unrelated. @Andy-MS I tried to play around with the |
|
Fixed |
KSXGitHub
pushed a commit
to KSXGitHub/DefinitelyTyped
that referenced
this pull request
May 12, 2018
* [node] Sync v8 and v9 * sync vm test added in v8 only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change. (Run with
npm test.)Follow the advice from the readme.
Avoid common mistakes.
Run
npm run lint package-name(ortscif notslint.jsonis present).Provide a URL to documentation or source code which provides context for the suggested changes:
https://nodejs.org/api/https.html#https_https_request_options_callback
https://nodejs.org/api/crypto.html#crypto_cipher_setautopadding_autopadding
https://nodejs.org/api/crypto.html#crypto_cipher_setaad_buffer
https://nodejs.org/api/crypto.html#crypto_decipher_setauthtag_buffer
https://nodejs.org/api/crypto.html#crypto_decipher_setautopadding_autopadding
https://nodejs.org/api/crypto.html#crypto_decipher_setaad_buffer
https://nodejs.org/dist/latest-v8.x/docs/api/console.html#console_console_debug_data_args
https://nodejs.org/dist/latest-v8.x/docs/api/stream.html#stream_readable_readablehighwatermark
https://nodejs.org/dist/latest-v8.x/docs/api/stream.html#stream_writable_writablehighwatermark
https://nodejs.org/dist/latest-v8.x/docs/api/zlib.html#zlib_zlib_deflate_buffer_options_callback
https://nodejs.org/dist/latest-v8.x/docs/api/modules.html#modules_module_builtinmodules
Increase the version number in the header if appropriate.
If you are making substantial changes, consider adding a
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.