Change "object" to "Object" in index.d.ts#16271
Closed
jbeard4 wants to merge 1 commit intoDefinitelyTyped:masterfrom
Closed
Change "object" to "Object" in index.d.ts#16271jbeard4 wants to merge 1 commit intoDefinitelyTyped:masterfrom
jbeard4 wants to merge 1 commit intoDefinitelyTyped:masterfrom
Conversation
"object" is now a keyword in Typescript. In Typescript 2.1, this throws an error "Cannot find name 'object'." This change resolves the error.
Member
|
types/es6-shim/index.d.ts to author (@rbuckton). Could you review this PR? Checklist
|
|
We should probably stop trying to duplicate |
mhegazy
suggested changes
May 3, 2017
Contributor
mhegazy
left a comment
There was a problem hiding this comment.
This is not the correct change. this will break TS 2.2 users.
Contributor
|
I wounder if we just should deprecate this package all together. |
Collaborator
|
Once we get microsoft/TypeScript#15780 merged, we can look into andy's comment. I recommend that we don't take this change. |
Collaborator
|
@jbeard4 If you still require TypeScript 2.1 support you can use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"object" is now a keyword in Typescript. In Typescript 2.1, this throws an error "Cannot find name 'object'." This change resolves the error.
Please fill in this template.
npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
tslint.jsoncontaining{ "extends": "dslint/dt.json" }.