jsdiag/jsdiag.d.ts

Checklist

• is correct naming convention?
  • https://www.npmjs.com/package/jsdiag
  • http://bower.io/search/?q=jsdiag
  • others?
• has a test file? (jsdiag-tests.ts or jsdiag-tests.tsx)
• pass the Travis CI test?

Checklist:
jsdiag/jsdiag.d.ts - what's the problem with the naming convention? It has passed the Travis CI test before: #12288

We got an email-request to move the PR to the types-2.0 branch which we did. The compile errors listed below do not seem to have anything to do with our files.

Failing tests here are OK, they are fixed by #12344.

types-2.0 packages use a different structure than master.
Also, it looks like the package comes bundled with its own types.

The naming convention error is just there because there is no NPM package with that name.

Thanks for your cooperation. We have changed the dir structure to comply with the types-2.0 rules. Here it is:

https://github.com/MindfusionSoftware/DefinitelyTyped/tree/types-2.0/jsdiag

Should we close this PR and open a new one for that?

You could, but I still wonder why you need to make a PR to DefinitelyTyped if the types are already bundled into the package.

Could you clarify what "bundled into the package" means?

We are sending you a PR because our users asked us to add the mindfusion definitions at the official @types repository. They want to use the angular-cli tool which pulls definitions from DefinitelyTyped.

For NPM packages at least, we would absolutely want typings to be bundled -- users only need to call npm install once, typings are guaranteed to be up-to-date, and package authors don't need to wait for their PR to be accepted to DefinitelyTyped.

When I go to http://www.mindfusion.eu/javascript-diagram.html and download the trial, I get a ZIP archive containing jsdiag.d.ts. I don't know how exactly people will be installing jsdiag into their projects, but possibly the same process that installs .js files could install jsdiag.d.ts as well.

If you think that would be too difficult, we could accept a duplicate copy of it into DefinitelyTyped; but any time you wanted to update the types, you would need to make a PR here.