[@types/billplz] added TypeScript 2.0 type definitions for node-billplz#12337
Closed
Akim95 wants to merge 2 commits into
Closed
[@types/billplz] added TypeScript 2.0 type definitions for node-billplz#12337Akim95 wants to merge 2 commits into
Akim95 wants to merge 2 commits into
Conversation
Member
|
billplz/index.d.ts Checklist
|
|
Failing tests here are OK, they are fixed by #12344. |
|
Why not directly bundle typings in the repository? |
Contributor
Author
|
Maybe I'll sent a pull request to that repo for the next release. I need to discuss first. 👍 |
Member
|
We recommend to talking first in that repository. |
Contributor
Author
|
I think we can hold this pull request until I done with that repository. 🚶 |
Contributor
Author
|
This type definition already bundled with npm package itself. |
|
Thanks! By the way, the definition header is no longer needed. The TypeScript compiler ignores those; they are only for use by DefinitelyTyped. |
Contributor
Author
|
Ok, I'll remove it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
types-2.0branch.If adding a new definition:
tscwithout errors.