Fix CTD tracklet-age reset writing to a non-existent attribute - #3404
Merged
C-Achard merged 1 commit intoJul 16, 2026
Merged
Conversation
When a frame lost all individuals (NMS mask all-False), the reset branch assigned self._idx_ages = None, but the tracking-age attribute is _ctd_track_ages (initialised in __init__ and used by _ctd_tracking_postprocess). _idx_ages is never read anywhere, so the intended reset silently did nothing and a dead attribute was created. As a result _ctd_track_ages kept its stale values; on the next BU-seeded frame the OKS-NMS ordering was biased toward stale-old indices, retaining the wrong pose/identity, and the bias compounded over subsequent frames. Reset the correct attribute.
9 tasks
C-Achard
approved these changes
Jul 16, 2026
C-Achard
merged commit Jul 16, 2026
d35dd81
into
DeepLabCut:external/hwang-misc-fixes
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a frame lost all individuals (NMS mask all-False), the reset branch assigned self._idx_ages = None, but the tracking-age attribute is _ctd_track_ages (initialised in init and used by _ctd_tracking_postprocess). _idx_ages is never read anywhere, so the intended reset silently did nothing and a dead attribute was created.
As a result _ctd_track_ages kept its stale values; on the next BU-seeded frame the OKS-NMS ordering was biased toward stale-old indices, retaining the wrong pose/identity, and the bias compounded over subsequent frames. Reset the correct attribute.