Fix CondFromModel loading the config path as its snapshot - #3402
Closed
Denny-Hwang wants to merge 1 commit into
Closed
Fix CondFromModel loading the config path as its snapshot#3402Denny-Hwang wants to merge 1 commit into
Denny-Hwang wants to merge 1 commit into
Conversation
CondFromModel.__init__ set snapshot_path = Path(config_path), a copy-paste error that overwrote the snapshot path with the config path. When BU conditions were configured the documented way (inference.conditions.config_path + snapshot_path), the model tried to torch.load() the pytorch_config.yaml instead of the .pt snapshot and failed. Use snapshot_path for the snapshot.
Collaborator
|
correct fix, but already addressed in #3387. Closing this in favor of that PR. Thanks for the contribution anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CondFromModel.init set snapshot_path = Path(config_path), a copy-paste error that overwrote the snapshot path with the config path. When BU conditions were configured the documented way (inference.conditions.config_path + snapshot_path), the model tried to torch.load() the pytorch_config.yaml instead of the .pt snapshot and failed. Use snapshot_path for the snapshot.