Fix NaN handling in PredictKeypointIdentities postprocessor#3378
Draft
deruyter92 wants to merge 1 commit into
Draft
Fix NaN handling in PredictKeypointIdentities postprocessor#3378deruyter92 wants to merge 1 commit into
deruyter92 wants to merge 1 commit into
Conversation
C-Achard
approved these changes
Jun 22, 2026
Comment on lines
+510
to
+512
| heatmap_indices = np.zeros((num_keypoints, 2), dtype=int) | ||
| if np.any(valid): | ||
| heatmap_indices[valid] = np.rint(xy[valid]).astype(int) |
Collaborator
There was a problem hiding this comment.
Could we shorten this by directly using the valid mask on heatmap_indices ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3376 - RuntimeWarning: invalid value encountered in cast during analyze_videos on multi-animal models with identity enabled. PAF assembly leaves missing bodyparts as NaN; PredictKeypointIdentities now indexes the identity heatmap using only finite x/y coordinates and skips invalid keypoints.
Added a new test that reproduces the original issue, which is now fixed: tests/pose_estimation_pytorch/data/test_postprocessor.py::test_predict_keypoint_identities_handles_nan_keypoints