Update deeplabcut-docker - version 0.1.0#3345
Open
deruyter92 wants to merge 2 commits into
Open
Conversation
C-Achard
reviewed
May 26, 2026
Collaborator
C-Achard
left a comment
There was a problem hiding this comment.
Thanks for the changes!
Depending on usefulness feel free to add some of the suggested changes below. The default token is probably the most important point there.
C-Achard
approved these changes
May 27, 2026
Collaborator
C-Achard
left a comment
There was a problem hiding this comment.
I would suggest adding warnings for empty tokens/disabling auth given the risks documented, otherwise LGTM, thanks!
- bugfix: NOTEBOOK_TOKEN value was never evaluated. This is now fixed - add features: add supplementary group args; improve logging and exit status; add warning for empty notebook token; allow running with local image - clean Dockerfile: update default dlc version 3.0; add exec jupyter entrypoint; add warning for empty notebook.
2a123a0 to
bd69be1
Compare
Collaborator
Author
|
All comments are addressed. Cleaned up the history so it can be merged without squashing (this preserves the isolated version bump commit, which is preferable). |
Collaborator
Author
|
@stes, as the original author of this package we would love hear your feedback, if you have any! Let us know if you would be interested in reviewing this PR. Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the downstream package
deeplabcut-dockerwith the new DeepLabCut 3.0 release and fixes some final issues before release of the new package (see version bump PR #3351). Note that these are minor additions to a larger previous update in PR #3291.changes: