Fix hardcoded GUI icon path - #3200
Merged
Merged
Conversation
Before, when an absolute path was used, this resulted in a crash when loading GUI from a different directory. (Rescaling the icon when it is null). This is fixed by making the path relative and also adding a null-check.
deruyter92
marked this pull request as ready for review
February 6, 2026 08:59
Collaborator
|
Could we use importlib.resources ? I think it is more standard/robust but otherwise this is fine |
C-Achard
requested changes
Feb 6, 2026
C-Achard
left a comment
Collaborator
There was a problem hiding this comment.
I think this would be best moving forward, lmk @deruyter92
Co-authored-by: Cyril Achard <cyril.achard@alumni.epfl.ch>
C-Achard
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a small issue regarding the scaling of the GUI icon pixmap in
window.py.The hardcoded path:
fails when the GUI is launched from any directory other than the project root, causing QPixmap to return a null pixmap. When scaled() is then called on this null pixmap, Qt raises an error.
This is now fixed by using a relative path and a null-check for the pixmap.