Skip to content

Refactor stackwalker #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhengyu123 merged 11 commits into from
Apr 9, 2026
Merged

Refactor stackwalker #451

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
df4d238
v0
zhengyu123 Apr 2, 2026
1088c74
v1
zhengyu123 Apr 3, 2026
7f303a7
v2
zhengyu123 Apr 3, 2026
9a9de6c
Fix VMMethod::validatedId() crash
zhengyu123 Apr 7, 2026
6a5924b
Revert previous commit
zhengyu123 Apr 7, 2026
44fb879
Fix memory ordering and add comment
zhengyu123 Apr 8, 2026
a839b3c
Merge branch 'main' into zgu/refactor-stackwalk
zhengyu123 Apr 8, 2026
b035e63
Code review
zhengyu123 Apr 8, 2026
f9f527f
Code review
zhengyu123 Apr 8, 2026
8fabf90
Review by Opus 4.6
zhengyu123 Apr 8, 2026
0af13ba
Merged https://github.com/DataDog/java-profiler/pull/455
zhengyu123 Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix memory ordering and add comment
  • Loading branch information
@zhengyu123
zhengyu123 committed Apr 8, 2026
commit 44fb8799bc7848226fb1761c053787412a12a720
1 change: 1 addition & 0 deletions ddprof-lib/src/main/cpp/hotspot/jitCodeCache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ void JNICALL JitCodeCache::DynamicCodeGenerated(jvmtiEnv *jvmti, const char *nam
CodeHeap::setInterpreterStart(address);
} else if (strcmp(name, "call_stub") == 0) {
_call_stub_begin.store(address, std::memory_order_relaxed);
// This fence ensures that _call_stub_begin is visible before _call_stub_end, so that isCallStub() works correctly
std::atomic_thread_fence(std::memory_order_release);
_call_stub_end.store((const char *)address + length, std::memory_order_relaxed);
}
Expand Down
2 changes: 1 addition & 1 deletion ddprof-lib/src/main/cpp/hotspot/jitCodeCache.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class JitCodeCache {
const void *address, jint length);

static inline bool isCallStub(const void *address) {
return _call_stub_end.load(std::memory_order_relaxed) != nullptr &&
return _call_stub_end.load(std::memory_order_acquire) != nullptr &&
address >= _call_stub_begin.load(std::memory_order_relaxed) &&
address < _call_stub_end.load(std::memory_order_relaxed);
Comment thread
zhengyu123 marked this conversation as resolved.
Outdated
}
Expand Down