Skip to content

Safe fetch 64-bit value and pointer #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhengyu123 merged 5 commits into from
Jul 22, 2025
Merged

Safe fetch 64-bit value and pointer #247

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e2a715
v0
zhengyu123 Jul 18, 2025
ae754ea
v1
zhengyu123 Jul 21, 2025
d519dd2
Fix
zhengyu123 Jul 21, 2025
dce4c5f
v2
zhengyu123 Jul 21, 2025
27b5838
Remove old safe access handler
zhengyu123 Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
v2
  • Loading branch information
@zhengyu123
zhengyu123 committed Jul 21, 2025
commit dce4c5fa22329a0ae0b0563ab1d5cb88d3548b72
8 changes: 4 additions & 4 deletions ddprof-lib/src/main/cpp/safeAccess.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ extern "C" int64_t safefetch64_cont(int64_t* adr, int64_t errValue);
#endif

/**
Loading a 32-bit value from specific address, the errValue will be returned
Loading a 32-bit/64-bit value from specific address, the errValue will be returned
if the address is invalid.
The load is protected by the 'handle_safefetch` signal handler, who sets next `pc`
to `safefetch32_cont`, upon returning from signal handler, `safefetch32_cont` returns `errValue`
to `safefetch32_cont/safefetch64_cont`, upon returning from signal handler,
`safefetch32_cont/safefetch64_cont` returns `errValue`
**/

#if defined(__x86_64__)
#ifdef __APPLE__
asm(R"(
Expand Down Expand Up @@ -74,7 +74,7 @@ extern "C" int64_t safefetch64_cont(int64_t* adr, int64_t errValue);
.globl safefetch32_impl
.hidden safefetch32_impl
.type safefetch32_imp, %function
safefetch64_impl:
safefetch32_impl:
movl (%rdi), %eax
ret
.globl safefetch32_cont
Expand Down
Loading