Skip to content

Adopt openjdk safefetch #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhengyu123 merged 15 commits into from
Jul 18, 2025
Merged

Adopt openjdk safefetch #246

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f523bb2
v0
zhengyu123 Jul 14, 2025
35576dc
v1
zhengyu123 Jul 15, 2025
21f3287
v3
zhengyu123 Jul 15, 2025
fc66365
Fix the assembler gradle task
jbachorik Jul 16, 2025
7b48662
v5
zhengyu123 Jul 16, 2025
ab1b644
Fix safefetch handler
zhengyu123 Jul 16, 2025
bef7200
context_pc for aarch64 Linux
zhengyu123 Jul 16, 2025
aca18b7
fix
zhengyu123 Jul 16, 2025
8ac912e
Fix
zhengyu123 Jul 16, 2025
8d20ad6
fix
zhengyu123 Jul 16, 2025
33261bc
Use inline assembly
zhengyu123 Jul 17, 2025
ca9c47b
fix
zhengyu123 Jul 17, 2025
66c69ad
Cleanup
zhengyu123 Jul 17, 2025
ca37ca6
formatting
zhengyu123 Jul 17, 2025
1c299c4
add comment
zhengyu123 Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
v0
  • Loading branch information
@zhengyu123
zhengyu123 committed Jul 14, 2025
commit f523bb2f604c79a38ad878fffee2e458a112b37a
5 changes: 4 additions & 1 deletion ddprof-lib/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,7 @@ tasks.whenTaskAdded { task ->
if (compileTask != null) {
dependsOn compileTask
}
dependsOn asmTask
linkerArgs.addAll(config.linkerArgs)
toolChain = task.toolChain
targetPlatform = task.targetPlatform
Expand Down Expand Up @@ -604,7 +605,9 @@ tasks.register('javadocJar', Jar) {
from javadoc.destinationDir
}


tasks.register('asmTask', Exec) {
commandLine 'clang', '-D__aarch64__', 'src/main/asm/safefetch.S', '-o', 'build/obj/safefetch.o'
}

tasks.register('scanBuild', Exec) {
workingDir "${projectDir}/src/test/make"
Expand Down
53 changes: 53 additions & 0 deletions ddprof-lib/src/main/asm/safefetch.S
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@

#define DECLARE_FUNC(func) \
.globl func %% \
.hidden func %% \
.type func, %function %% \
func

#if defined(__x86_64__)
.text

# Support for int SafeFetch32(int* address, int defaultval);
#
# %rdi : address
# %esi : defaultval
DECLARE_FUNC(SafeFetch32_impl):
DECLARE_FUNC(_SafeFetch32_fault):
movl (%rdi), %eax # load target value, may fault
ret
DECLARE_FUNC(_SafeFetch32_continuation):
movl %esi, %eax # return default
ret

#elif defined(__aarch64__)
#ifdef __APPLE__
# Support for int SafeFetch32(int* address, int defaultval);
#
# x0 : address
# w1 : defaultval

# needed to align function start to 4 byte
.align 6
DECLARE_FUNC(SafeFetch32_impl):
DECLARE_FUNC(_SafeFetch32_fault):
ldr w0, [x0]
ret
DECLARE_FUNC(_SafeFetch32_continuation):
mov x0, x1
ret
#else
# Support for int SafeFetch32(int* address, int defaultval);
#
# x0 : address
# x1 : defaultval
DECLARE_FUNC(SafeFetch32_impl):
DECLARE_FUNC(_SafeFetch32_fault):
ldr w0, [x0]
ret
DECLARE_FUNC(_SafeFetch32_continuation):
mov x0, x1
ret
#endif // __APPLE__

#endif