Skip to content

Potential memory leak and race with the JVMTI wallclock sampler #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhengyu123 merged 29 commits into from
Jul 9, 2025
Merged

Potential memory leak and race with the JVMTI wallclock sampler #234

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
60d0fd4
Potential memory leak with the JVMTI wallclock sampler
zhengyu123 Jun 30, 2025
4900544
v1
zhengyu123 Jun 30, 2025
0315204
Don't sample terminated thread
zhengyu123 Jun 30, 2025
7b7e1cf
v2
zhengyu123 Jul 1, 2025
fd3461a
v3
zhengyu123 Jul 1, 2025
e903361
v4
zhengyu123 Jul 1, 2025
0eda2cc
Safe access
zhengyu123 Jul 2, 2025
194a62c
Fix thread state
zhengyu123 Jul 2, 2025
fb7572a
v5
zhengyu123 Jul 2, 2025
0643123
Cleanup
zhengyu123 Jul 2, 2025
a17691b
Cleanup
zhengyu123 Jul 2, 2025
8283f26
safeFetch impl
zhengyu123 Jul 3, 2025
79f57cf
jdk11 support
Jul 3, 2025
8e37863
v6
zhengyu123 Jul 3, 2025
57e6022
enhance and cleanup
zhengyu123 Jul 7, 2025
c4182d2
fix nullptr deference
zhengyu123 Jul 7, 2025
b018305
More cleanup
zhengyu123 Jul 7, 2025
ecf380f
Erwan's finding
zhengyu123 Jul 8, 2025
bafea6f
Fixed memory leak found by Erwan
zhengyu123 Jul 8, 2025
56dc6f6
[Automated] Bump dev version to 1.29.0
Jul 1, 2025
8f6b5e2
Update the sonatype repos (#235)
jbachorik Jul 1, 2025
44531b0
Fix artifact download URL
jbachorik Jul 2, 2025
edcb336
Split debug (#233)
r1viollet Jul 3, 2025
c0d8e91
Add the micro-benchmark for thread filtering (#237)
jbachorik Jul 4, 2025
6b7e662
Flaky test - j9 OSR (#239)
r1viollet Jul 7, 2025
cddfbf2
Fix flaky allocation test (#241)
r1viollet Jul 8, 2025
e9803d1
jbachorik's comments
zhengyu123 Jul 9, 2025
0071c00
More jbachorik's comments
zhengyu123 Jul 9, 2025
a1db674
Cleanup thread local references
zhengyu123 Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Flaky test - j9 OSR (#239) 
Skip zing and j9 flaky tests
  • Loading branch information
@r1viollet @zhengyu123
r1viollet authored and zhengyu123 committed Jul 9, 2025
commit 6b7e662c479c51a4f8853c5b7f95d8768f1e865c
8 changes: 8 additions & 0 deletions ddprof-test/src/test/java/com/datadoghq/profiler/alloc/AllocationProfilerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ protected boolean isPlatformSupported() {

@RetryingTest(5)
public void shouldGetObjectAllocationSamples() throws InterruptedException {

// We seem to hit issues on j9:
// OSR (On stack replacement) creates crashes with the profiler.
// ----------- Stack Backtrace -----------
// prepareForOSR+0xbf (0x00007F51062A4DDF [libj9jit29.so+0x4a4ddf])
if (Platform.isJ9() && !Platform.isJavaVersionAtLeast(8)) {
return;
}
Assumptions.assumeFalse(isAsan() || isTsan());

AllocatingTarget target1 = new AllocatingTarget();
Expand Down
15 changes: 10 additions & 5 deletions ...of-test/src/test/java/com/datadoghq/profiler/wallclock/ContendedWallclockSamplesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,18 @@ public void after() {
@TestTemplate
@ValueSource(strings = {"vm", "vmx", "fp", "dwarf"})
public void test(@CStack String cstack) {
String config = System.getProperty("ddprof_test.config");
boolean isSanitizer = config.endsWith("san");
boolean isJvmci = System.getProperty("java.vm.version", "").contains("jvmci");
assumeFalse(Platform.isZing() || Platform.isJ9());
// Skip test entirely on unsupported JVMs (don't use assumeFalse which gets retried)
if (Platform.isZing() || Platform.isJ9()) {
return;
}
// Running vm stackwalker tests on JVMCI (Graal), JDK 24, aarch64 and with a sanitizer is crashing in a weird place
// This looks like the sanitizer instrumentation is breaking the longjump based crash recovery :(
assumeFalse(Platform.isJavaVersionAtLeast(24) && isJvmci && Platform.isAarch64() && cstack.startsWith("vm") && isSanitizer);
String config = System.getProperty("ddprof_test.config");
boolean isJvmci = System.getProperty("java.vm.version", "").contains("jvmci");
boolean isSanitizer = config.endsWith("san");
if (Platform.isJavaVersionAtLeast(24) && isJvmci && Platform.isAarch64() && cstack.startsWith("vm") && isSanitizer) {
return;
}

long result = 0;
for (int i = 0; i < 10; i++) {
Expand Down