Skip to content

Remap thread id to avoid bitmap contention #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhengyu123 wants to merge 7 commits into from
Closed

Remap thread id to avoid bitmap contention #223

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4bfccf5
v0
Jun 10, 2025
a9eda77
Remove unnecessary import
Jun 10, 2025
cc95793
Rename
Jun 11, 2025
bb2a116
Added assertion for potential mapped thread id overflow
Jun 11, 2025
a3d2477
Reverse lower 16 bits, instead of swapping lower 2 bytes
zhengyu123 Jun 12, 2025
0b128b5
jbachorik's comment
zhengyu123 Jun 16, 2025
463e8eb
Sign the patch
zhengyu123 Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
jbachorik's comment
  • Loading branch information
@zhengyu123
zhengyu123 committed Jun 16, 2025
commit 0b128b57ec177020c18beb51f6f5caef93519463
1 change: 1 addition & 0 deletions ddprof-lib/src/main/cpp/threadFilter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ void ThreadFilter::clear() {
_size = 0;
}

// The mapping has to be reversible: f(f(x)) == x
int ThreadFilter::mapThreadId(int thread_id) {
Comment thread
zhengyu123 marked this conversation as resolved.
// We want to map the thread_id inside the same bitmap
static_assert(BITMAP_SIZE >= (u16)0xffff, "Potential verflow");
Expand Down
Loading