Skip to content

Refactor thread filter mechanisms #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
r1viollet wants to merge 12 commits into from
Closed

Refactor thread filter mechanisms #209

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3b91530
Bench - Add a benchmark for the thread filter mechanism
r1viollet Mar 21, 2025
913d2b6
Bench - Add a benchmark for the thread filter mechanism
r1viollet Mar 21, 2025
873fcb2
thread filter - reverse lower bits
r1viollet Mar 21, 2025
be0752b
Merge branch 'r1viollet/bench_thread_filter' of github.com:DataDog/ja…
r1viollet Mar 21, 2025
0f92917
thread filter - adjust implementation
r1viollet Apr 3, 2025
258f23e
thread filter
r1viollet Apr 28, 2025
1d4efc0
thread filter - refactor recording implementation
r1viollet Apr 28, 2025
115a60a
thread filter - add a free list
r1viollet Apr 28, 2025
efa094e
Thread filter - add a table with linear probing
r1viollet Jun 25, 2025
1be1c3a
Thread filter bench - Add parameters to run different configurations …
r1viollet Jun 25, 2025
4772169
Merge branch 'main' of github.com:DataDog/java-profiler into r1violle…
r1viollet Jun 25, 2025
60ef060
Minor thread filter adjustement
r1viollet Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Minor thread filter adjustement 
remove the logs
  • Loading branch information
@r1viollet
r1viollet committed Jun 25, 2025
commit 60ef0601ab11807674bb5be7287671b74c67e27e
10 changes: 8 additions & 2 deletions ...stest/src/jmh/java/com/datadoghq/profiler/stresstest/scenarios/ThreadFilterBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public class ThreadFilterBenchmark extends Configuration {
@Setup(Level.Trial)
public void setup() throws IOException {
System.out.println("Setting up benchmark...");
System.out.println("Thread filters enabled: " + useThreadFilters);
System.out.println("Creating thread pool with " + NUM_THREADS + " threads");
executorService = Executors.newFixedThreadPool(NUM_THREADS);
System.out.println("Getting profiler instance");
Expand Down Expand Up @@ -110,6 +111,7 @@ public void tearDown() {
// Stop the profiler if it's active
try {
profiler.stop();
System.out.println("Profiler stopped.");
} catch (IllegalStateException e) {
System.out.println("Profiler was not active at teardown.");
}
Expand Down Expand Up @@ -144,6 +146,10 @@ public void tearDown() {
}
}

public void setUseThreadFilters(boolean useThreadFilters) {
this.useThreadFilters = useThreadFilters;
}

@Benchmark
@BenchmarkMode(Mode.Throughput)
@Fork(value = 1, warmups = 1)
Expand All @@ -156,7 +162,7 @@ public long threadFilterStress() throws InterruptedException {
startLatch = new CountDownLatch(NUM_THREADS);
stopLatch = new CountDownLatch(NUM_THREADS);

// Start all worker threads
// Start all worker threads[]
for (int i = 0; i < NUM_THREADS; i++) {
final int threadId = i;
executorService.submit(() -> {
Expand Down Expand Up @@ -242,4 +248,4 @@ public long threadFilterStress() throws InterruptedException {
stopLatch.await();
return operationCount.get();
}
}
}
Loading