Skip to content

Skip tests based on git changes on GitLab #9039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smola merged 7 commits into from
Jun 30, 2025
+88 −2
Merged

Skip tests based on git changes on GitLab #9039

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3fc64a1
Skip tests based on git changes on GitLab
smola Jun 26, 2025
283207e
Use DDCI_PULL_REQUEST_TARGET_SHA
smola Jun 27, 2025
15a1ad8
Add script to infer base reference
smola Jun 27, 2025
a1ec019
Infer base branch
smola Jun 27, 2025
0dccb3d
Fetch GitHub token from AWS SSM
smola Jun 30, 2025
b06a47b
Fix AWS SSM token name
smola Jun 30, 2025
bf4cb57
Extract gitlab_base_ref_params
smola Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix AWS SSM token name
  • Loading branch information
@smola
smola committed Jun 30, 2025
commit b06a47b9fd6422389d94e990ec51044b1c98422b
2 changes: 1 addition & 1 deletion .gitlab/find-gh-base-ref.sh
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@bric3 bric3 Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Did you thought about making this part of our gradle itself. Not that I'm asking for it specifically. As I would like to avoid adding yet another groovy scripting at this time.

Also, I wonder does our gitlab CI have this resolved ?

cc @randomanderson

Copy link
Copy Markdown
Member Author

@smola smola Jun 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you thought about making this part of our gradle itself.

Can be done at gradle level. A bash script for CI seemed pretty self-contained and easily debuggable though.

Also, I wonder does our gitlab CI have this resolved ?

Not supported by GitLab, because GitHub PRs are not native to GitLab CI, and we do not use GitLab MR. We have an internal solution at DD that requires migrating to a new CI system for GitLab. That's apparently a lot of work for the repo since it was not used since the beginning.

In our current setup, this is the recommended way. I took it from dd-trace-py.

Copy link
Copy Markdown
Contributor

@bric3 bric3 Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for the info !

Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if [[ -z "${GITHUB_TOKEN:-}" ]]; then
echo "aws is not installed, please install it" >&2
exit 1
fi
GITHUB_TOKEN=$(aws ssm get-parameter --name "ci.$CI_PROJECT_NAME.gh_token" --with-decryption --query "Parameter.Value" --output text)
GITHUB_TOKEN=$(aws ssm get-parameter --name "ci.$CI_PROJECT_NAME.gh_release_token" --with-decryption --query "Parameter.Value" --output text)
if [[ -z "${GITHUB_TOKEN}" ]]; then
echo "Failed to fetch GITHUB_TOKEN from AWS SSM" >&2
exit 1
Expand Down