Skip to content

Add PR performance gate #8970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bric3 merged 12 commits into from
Jun 25, 2025
Merged

Add PR performance gate #8970

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
51cdcd5
feat(ci): PR performance gate
bric3 Jun 11, 2025
1e75a62
chore(ci): Review comments
bric3 Jun 12, 2025
109573f
feat(ci): Explicitly rely on job artifacts, drop dacapo
bric3 Jun 12, 2025
3f56fdf
fix(ci): revert removal of ARTIFACTSDIR for bp-runner.fail-on-regress…
bric3 Jun 12, 2025
52b5b58
chore(ci): replace ARTIFACTSDIR by CI_PROJECT_DIR for bp-runner.fail-…
bric3 Jun 12, 2025
4018257
chore(ci): Move threshold to 10%
bric3 Jun 12, 2025
e6af269
chore(ci): Allow failure on PR gate to exercise it
bric3 Jun 13, 2025
5bf274c
chore(ci): Disable failure but increase regression threshold (to be r…
bric3 Jun 18, 2025
59268cd
Merge remote-tracking branch 'origin/master' into bdu/pr-gate
bric3 Jun 24, 2025
460c5e4
Merge remote-tracking branch 'origin/master' into bdu/pr-gate
bric3 Jun 25, 2025
417db44
Merge remote-tracking branch 'origin/master' into bdu/pr-gate
bric3 Jun 25, 2025
333b53a
chore(ci): Choose 10% as threshold.
bric3 Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore(ci): Choose 10% as threshold. 
20% was chosen due to variability of the results on unrelated changes.

After discussion in lp-sync, 20% won't get us to move forward and entice to fix the problems. So instead choose a closer threshold to 10%.
  • Loading branch information
@bric3
bric3 committed Jun 25, 2025
commit 333b53aa0407febe06157f6517daff9e9f777bf5
2 changes: 1 addition & 1 deletion .gitlab/benchmarks/bp-runner.fail-on-regression.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ experiments:
- name: Regression Check
run: fail_on_regression
# Applies on all scenarios
regression_threshold: 20.0 # percents
regression_threshold: 10.0 # percents