Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
6980d02
remove backend request for diff
daniel-mohedano May 16, 2025
a7f738d
update PRInfo building to use partial information from CI vendors
daniel-mohedano May 20, 2025
a1238c0
synchronize repo unshallow with future, avoids performing several times
daniel-mohedano May 20, 2025
cbe2a95
add `default_branch` to settings response
daniel-mohedano May 22, 2025
b861e7f
update settings api test
daniel-mohedano May 22, 2025
cab317e
change repo unshallow synchronization from future-based to synchronized
daniel-mohedano May 22, 2025
e401549
include pr info checks to CITagsProviderTest
daniel-mohedano May 23, 2025
63e7236
add tests for prinfo merging
daniel-mohedano May 23, 2025
a109cfd
Revert "update PRInfo building to use partial information from CI ven…
daniel-mohedano Jun 2, 2025
4d18887
Revert "include pr info checks to CITagsProviderTest"
daniel-mohedano Jun 2, 2025
84e1c0f
Revert "add tests for prinfo merging"
daniel-mohedano Jun 2, 2025
ec152b6
base commit sha algorithm implementation
daniel-mohedano Jun 2, 2025
1e843af
example git repo for base commit sha testing
daniel-mohedano Jun 2, 2025
fc82fcc
simplify algo implementation for easier read
daniel-mohedano Jun 2, 2025
67339e9
implement git diff based on best candidate for base commit sha
daniel-mohedano Jun 2, 2025
bfd3ad4
add github actions cloning test
daniel-mohedano Jun 3, 2025
5ddb58c
add several testing cases and cleaned up debug messages
daniel-mohedano Jun 4, 2025
c558a86
remove repo_origin folder
daniel-mohedano Jun 4, 2025
eca82e1
Merge branch 'master' into daniel.mohedano/impacted-tests-update
daniel-mohedano Jun 4, 2025
0fac3ae
fix forbidden apis
daniel-mohedano Jun 4, 2025
0e6bc2d
remove smoke test (no backend implementation anymore)
daniel-mohedano Jun 4, 2025
2e3362f
remove FileDiff
daniel-mohedano Jun 5, 2025
4198fe3
correctly reset all settings tags for mock backend
daniel-mohedano Jun 5, 2025
a99cff8
create isBlank method to avoid double negation with isNotBlank
daniel-mohedano Jun 5, 2025
f060e73
clean up base branch sha logic
daniel-mohedano Jun 6, 2025
ce0da33
fix code violation
daniel-mohedano Jun 6, 2025
2970e68
junit 4 test import wildcard
daniel-mohedano Jun 6, 2025
99980be
use relative paths in remotes and add remote origin to resources
daniel-mohedano Jun 6, 2025
a738112
add javadoc and update tests for Strings.isBlank
daniel-mohedano Jun 17, 2025
612ba54
Merge branch 'master' into daniel.mohedano/impacted-tests-update
daniel-mohedano Jun 17, 2025
d21d3b7
Merge branch 'master' into daniel.mohedano/impacted-tests-update
daniel-mohedano Jun 20, 2025
67cdbe7
Merge branch 'master' into daniel.mohedano/impacted-tests-update
daniel-mohedano Jun 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add javadoc and update tests for Strings.isBlank
  • Loading branch information
daniel-mohedano committed Jun 17, 2025
commit a7381120fe7f5a5a410d58f8298edaca7308b0ae
7 changes: 7 additions & 0 deletions internal-api/src/main/java/datadog/trace/util/Strings.java
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,13 @@ public static boolean isNotBlank(String s) {
return false;
}

/**
* Checks that a string is blank, i.e. doest not contain characters or is null
*
* @param s The string to be checked
* @return {@code true} if string is blank (string is {@code null}, empty, or contains only
* whitespace characters), {@code false} otherwise
*/
public static boolean isBlank(String s) {
Comment thread
daniel-mohedano marked this conversation as resolved.
return !isNotBlank(s);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,14 @@ class StringsTest extends DDSpecification {
"hélló wórld" | 5 | "hélló"
}

def "test isNotBlank: #input"() {
def "test isNotBlank and isBlank: #input"() {
when:
def notBlank = Strings.isNotBlank(input)
def isBlank = Strings.isBlank(input)

then:
notBlank == expected
isBlank == !notBlank

where:
input | expected
Expand Down
Loading