Skip to content

Global tags support for Data Streams #8852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kr-igor wants to merge 10 commits into from
Closed

Global tags support for Data Streams #8852

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
eb9456d
Added addGlobalTag method
kr-igor May 19, 2025
5efd832
Added service_type tags
kr-igor May 19, 2025
baeff39
Spotless apply
kr-igor May 19, 2025
c1b257d
Spotless apply
kr-igor May 20, 2025
3a7fb65
Merge branch 'master' into kr-igor/app-type-support-dsm
kr-igor May 20, 2025
3b97b2c
Spotless apply, again
kr-igor May 20, 2025
8c8605a
Merge branch 'master' into kr-igor/app-type-support-dsm
kr-igor May 20, 2025
4f7254e
Added temporary debug print statements
kr-igor May 20, 2025
ee7ee64
Removed debug logs
kr-igor May 20, 2025
c1b1b5c
Added global tags to tests
kr-igor May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added global tags to tests
  • Loading branch information
@kr-igor
kr-igor committed May 21, 2025
commit c1b1b5c5b2ffc5fdf1b4218c9ab639ab7f354785
47 changes: 23 additions & 24 deletions dd-trace-core/src/test/groovy/datadog/trace/core/datastreams/DataStreamsWritingTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ class DataStreamsWritingTest extends DDCoreSpecification {

when:
def dataStreams = new DefaultDataStreamsMonitoring(fakeConfig, sharedCommObjects, timeSource, { traceConfig })
dataStreams.addGlobalTag("global:value")
dataStreams.start()
dataStreams.add(new StatsPoint([], 9, 0, 10, timeSource.currentTimeNanos, 0, 0, 0, null))
dataStreams.add(new StatsPoint(["type:testType", "group:testGroup", "topic:testTopic"], 1, 2, 5, timeSource.currentTimeNanos, 0, 0, 0, null))
Expand Down Expand Up @@ -186,37 +187,33 @@ class DataStreamsWritingTest extends DDCoreSpecification {
assert unpacker.unpackString() == "Stats"
assert unpacker.unpackArrayHeader() == 2 // 2 groups in first bucket

Set availableSizes = [5, 6] // we don't know the order the groups will be reported
2.times {
int mapHeaderSize = unpacker.unpackMapHeader()
assert availableSizes.remove(mapHeaderSize)
if (mapHeaderSize == 5) { // empty topic group
assert unpacker.unpackString() == "PathwayLatency"
unpacker.skipValue()
assert unpacker.unpackString() == "EdgeLatency"
unpacker.skipValue()
assert unpacker.unpackString() == "PayloadSize"
unpacker.skipValue()
assert unpacker.unpackString() == "Hash"
assert unpacker.unpackLong() == 9
assert unpacker.unpackMapHeader() == 6

assert unpacker.unpackString() == "PathwayLatency"
unpacker.skipValue()
assert unpacker.unpackString() == "EdgeLatency"
unpacker.skipValue()
assert unpacker.unpackString() == "PayloadSize"
unpacker.skipValue()
assert unpacker.unpackString() == "Hash"
def hashValue = unpacker.unpackLong()
if (hashValue == 9) {
assert unpacker.unpackString() == "ParentHash"
assert unpacker.unpackLong() == 0
} else { //other group
assert unpacker.unpackString() == "PathwayLatency"
unpacker.skipValue()
assert unpacker.unpackString() == "EdgeLatency"
unpacker.skipValue()
assert unpacker.unpackString() == "PayloadSize"
unpacker.skipValue()
assert unpacker.unpackString() == "Hash"
assert unpacker.unpackLong() == 1
assert unpacker.unpackString() == "EdgeTags"
assert unpacker.unpackArrayHeader() == 1
assert unpacker.unpackString() == "global:value"
} else {
assert hashValue == 1
assert unpacker.unpackString() == "ParentHash"
assert unpacker.unpackLong() == 2
assert unpacker.unpackString() == "EdgeTags"
assert unpacker.unpackArrayHeader() == 3
assert unpacker.unpackArrayHeader() == 4
assert unpacker.unpackString() == "type:testType"
assert unpacker.unpackString() == "group:testGroup"
assert unpacker.unpackString() == "topic:testTopic"
assert unpacker.unpackString() == "global:value"
}
}

Expand All @@ -225,10 +222,11 @@ class DataStreamsWritingTest extends DDCoreSpecification {
assert unpacker.unpackArrayHeader() == 1
assert unpacker.unpackMapHeader() == 2
assert unpacker.unpackString() == "Tags"
assert unpacker.unpackArrayHeader() == 3
assert unpacker.unpackArrayHeader() == 4
assert unpacker.unpackString() == "partition:1"
assert unpacker.unpackString() == "topic:testTopic"
assert unpacker.unpackString() == "type:kafka_produce"
assert unpacker.unpackString() == "global:value"
assert unpacker.unpackString() == "Value"
assert unpacker.unpackLong() == 130

Expand Down Expand Up @@ -256,10 +254,11 @@ class DataStreamsWritingTest extends DDCoreSpecification {
assert unpacker.unpackString() == "ParentHash"
assert unpacker.unpackLong() == (hash == 1 ? 2 : 4)
assert unpacker.unpackString() == "EdgeTags"
assert unpacker.unpackArrayHeader() == 3
assert unpacker.unpackArrayHeader() == 4
assert unpacker.unpackString() == "type:testType"
assert unpacker.unpackString() == "group:testGroup"
assert unpacker.unpackString() == (hash == 1 ? "topic:testTopic" : "topic:testTopic2")
assert unpacker.unpackString() == "global:value"
}

assert unpacker.unpackString() == "ProductMask"
Expand Down